Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mqmw4-0004nJ-14 for pgsql-committers@arkaria.postgresql.org; Sat, 27 Nov 2021 01:55:28 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1mqmw2-0001NG-NF for pgsql-committers@arkaria.postgresql.org; Sat, 27 Nov 2021 01:55:26 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mqmw1-0001KO-2C for pgsql-committers@lists.postgresql.org; Sat, 27 Nov 2021 01:55:26 +0000 Received: from out4-smtp.messagingengine.com ([66.111.4.28]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mqmvy-0001sr-9L for pgsql-committers@lists.postgresql.org; Sat, 27 Nov 2021 01:55:24 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 1334A5C00DF; Fri, 26 Nov 2021 20:55:21 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Fri, 26 Nov 2021 20:55:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anarazel.de; h= date:from:to:cc:subject:in-reply-to:references:message-id :mime-version:content-type:content-transfer-encoding; s=fm3; bh= BLTF20Qqg3bdHsPj8DdUB+H1lojVYjJ5dVkfybi3lA0=; b=uWYF+5eNlTVWkFvQ gyhInqTjCFx88jeg5OSR6ACbd14XwcpdM8EJB6qAvQRdqkVxareoL2EXItD4OZlR fwgz5SWkioq7llqXIHhzwA34j/X/IQGnWynQO2Y5uPszriRd2U9COSppih1wJ0FQ 2Ih2SzSSxNmFijOvjsoDLtbwUgV4ydYrDKogB5jgRdNou48CMpBewl/14HuuOno1 3HILdKjAu1FrpzbwLOkSXASfi87GCJDm3eovE+2xB4FSDKNcCTq+YG3iUtey1YOD ejoEB98C/z6JMbf234DasQOUv3Vm44rI2ceK/HWedqwj4gRBnzGGdxKmEUHEZKVn g8kAyA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=BLTF20Qqg3bdHsPj8DdUB+H1lojVYjJ5dVkfybi3l A0=; b=AeEGcBUZ/WQGT/xo1HrbUgLXesZEpsb111kM/x1h/VqwVd1J32tvKIyg/ jHEHYg2kP1Fx1pH+KunfNdiQhpX3xmUExllf3Reg5aBD1LLuLOOzNYUapFNh/gNr O9DVoYz3Ffx6IdnFnKN8MHcNlq+S+nsDHm9HnyZ+HWwTvmKJnaUpz2UbZVP4R5Zm y+/PEF6CiOcldHjHvVSU+fzyOZn0HGah0xQYQhmnnp5Sivf9mcjLjQYuIjyUa0RG 560GRiwfuzi7U0CmIht2yXVhLMAhsV4sz2TUQl4rq9w1B+X2wRVOMHdVCs5xupU7 +Uj1DzXpYCRBoByvw53vjvArVRfiA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrheefgdegtdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvufgfjghfkfggtgfgsehtqhhmtddtreejnecuhfhrohhmpeetnhgurhgv shcuhfhrvghunhguuceorghnughrvghssegrnhgrrhgriigvlhdruggvqeenucggtffrrg htthgvrhhnpeeftddthfelhfefheehkeejgeehfeehvdfhgfdtieevudegveekleefgfdv geehvdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe grnhgurhgvshesrghnrghrrgiivghlrdguvg X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 26 Nov 2021 20:55:20 -0500 (EST) Date: Fri, 26 Nov 2021 17:55:17 -0800 From: Andres Freund To: Robert Haas , Tom Lane CC: pgsql-committers Subject: Re: pgsql: xlog.c: Remove global variables ReadRecPtr and EndRecPtr. User-Agent: K-9 Mail for Android In-Reply-To: References: <20211124231206.gbadj5bblcljb6d5@alap3.anarazel.de> <20211125010145.fqt4mlkhzyiz4wvw@alap3.anarazel.de> <359621.1637899369@sss.pgh.pa.us> Message-ID: <79346854-6ABD-4B96-9743-323CB85F1592@anarazel.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi,=20 On November 26, 2021 5:53:31 PM PST, Andres Freund = wrote: >Hi,=20 > >On November 26, 2021 7:24:15 AM PST, Robert Haas wrote: >>Fortunately, it seems to have been only a minor oversight=2E > Agreed=2E=20 I wonder if we should turn some of these ifdefs into something boiling dow= n to if (0) { ifdef body}=2E=2E=2E No need to make it impossible for the co= mpiler to help us in most of these cases=2E=2E=2E Andres --=20 Sent from my Android device with K-9 Mail=2E Please excuse my brevity=2E