Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1u27Ja-00DEDr-Ag for pgsql-committers@arkaria.postgresql.org; Tue, 08 Apr 2025 11:40:26 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1u27JY-007zzy-FY for pgsql-committers@arkaria.postgresql.org; Tue, 08 Apr 2025 11:40:24 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1u27JY-007zzq-4c for pgsql-committers@lists.postgresql.org; Tue, 08 Apr 2025 11:40:24 +0000 Received: from smtp.outgoing.loopia.se ([93.188.3.37]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1u27JV-0047iB-39 for pgsql-committers@lists.postgresql.org; Tue, 08 Apr 2025 11:40:24 +0000 Received: from s807.loopia.se (localhost [127.0.0.1]) by s807.loopia.se (Postfix) with ESMTP id 4689B2C05E9 for ; Tue, 08 Apr 2025 13:40:15 +0200 (CEST) Received: from s899.loopia.se (unknown [172.22.191.5]) by s807.loopia.se (Postfix) with ESMTP id 331312C3471; Tue, 08 Apr 2025 13:40:15 +0200 (CEST) Received: from s470.loopia.se (unknown [172.22.191.6]) by s899.loopia.se (Postfix) with ESMTP id 307462C8BAC6; Tue, 08 Apr 2025 13:40:15 +0200 (CEST) X-Virus-Scanned: amavisd-new at amavis.loopia.se X-Spam-Flag: NO X-Spam-Score: -1.2 X-Spam-Level: X-Spam-Status: No, score=-1.2 tagged_above=-999 required=6.2 tests=[ALL_TRUSTED=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1] autolearn=disabled Authentication-Results: s470.loopia.se (amavisd-new); dkim=pass (2048-bit key) header.d=yesql.se Received: from s980.loopia.se ([172.22.191.6]) by s470.loopia.se (s470.loopia.se [172.22.190.34]) (amavisd-new, port 10024) with LMTP id saCVvZK-djJJ; Tue, 8 Apr 2025 13:40:14 +0200 (CEST) X-Loopia-Auth: user X-Loopia-User: daniel@yesql.se X-Loopia-Originating-IP: 89.255.232.193 Received: from smtpclient.apple (customer-89-255-232-193.stosn.net [89.255.232.193]) (Authenticated sender: daniel@yesql.se) by s980.loopia.se (Postfix) with ESMTPSA id 8DA4522016A1; Tue, 08 Apr 2025 13:40:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yesql.se; s=loopiadkim1707475645; t=1744112414; bh=8s7z9Lls3LpGvM4UNWovF9GOxV3vsocMwpHB7L9bENs=; h=Subject:From:In-Reply-To:Date:Cc:References:To; b=wTHZyaJjejG+6LzM+efnkLO9UJBFhaVGPv98YNjsKEOFe50Tkw9cRWlAkKv49S/nN kOU3Kqy+hd7PNDG7R7/FzjfPxLqa2bv0xHn2rgjisSV48m2FGmaV1Fv1nVpku+HmCb ltvH3iT9cRGljNdcSX/axEu/11tP/wTuZT2F2EgL1TGWLdLK6pG1e7XbbpXO1DzYrA Im5Ft2Do+9yhRs6pSC4r6Rgv22KQFCSPxGDr/TgZpZ3ea4TE4iUW8QJUhp0RZmUoLg DbTMO/NmT8Mcn1gCyBd20n50TVnwU0vIkg6Xfp4WIikGGCJT8FJvQluRXOlCHPzcbb 5qcuOPpNydbVA== Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3776.700.51.11.1\)) Subject: Re: pgsql: Add support for basic NUMA awareness From: Daniel Gustafsson In-Reply-To: Date: Tue, 8 Apr 2025 13:40:04 +0200 Cc: pgsql-committers@lists.postgresql.org Content-Transfer-Encoding: quoted-printable Message-Id: <7ABC1680-3B82-4DD4-B9B7-BB4F74668B1A@yesql.se> References: To: Tomas Vondra X-Mailer: Apple Mail (2.3776.700.51.11.1) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk > On 7 Apr 2025, at 23:18, Tomas Vondra = wrote: >=20 > Add support for basic NUMA awareness dogfish is a little bit upset it seems. ninja: job failed: ccache gcc -Isrc/port/libpgport.a.p -Isrc/include = -I../pgsql/src/include -fdiagnostics-color=3Dalways = -D_FILE_OFFSET_BITS=3D64 -Wall -Winvalid-pch -O2 -g -fno-strict-aliasing = -fwrapv -fexcess-precision=3Dstandard -D_GNU_SOURCE -Wmissing-prototypes = -Wpointer-arith -Werror=3Dvla -Wendif-labels -Wmissing-format-attribute = -Wimplicit-fallthrough=3D3 -Wcast-function-type = -Wshadow=3Dcompatible-local -Wformat-security = -Wdeclaration-after-statement -Wmissing-variable-declarations = -Wno-format-truncation -Wno-stringop-truncation -fPIC -DFRONTEND -MD -MQ = src/port/libpgport.a.p/pg_numa.c.o -MF = src/port/libpgport.a.p/pg_numa.c.o.d -o = src/port/libpgport.a.p/pg_numa.c.o -c ../pgsql/src/port/pg_numa.c In file included from =1B[01m=1B[K../pgsql/src/include/postgres.h:49=1B[m=1B= [K, from =1B[01m=1B[K../pgsql/src/port/pg_numa.c:16=1B[m=1B[K: =1B[01m=1B[K../pgsql/src/include/utils/elog.h:79:10:=1B[m=1B[K = =1B[01;31m=1B[Kfatal error: =1B[m=1B[Kutils/errcodes.h: No such file or = directory 79 | #include =1B[01;31m=1B[K"utils/errcodes.h"=1B[m=1B[K | =1B[01;31m=1B[K^~~~~~~~~~~~~~~~~~=1B[m=1B[K compilation terminated. Looking at pg_numa.c, shouldn't the include of postgres.h have an = #ifndef FRONTEND guard for postgres_fe.h as well? -- Daniel Gustafsson