Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nXqFG-0007nf-Ub for pgsql-hackers@arkaria.postgresql.org; Fri, 25 Mar 2022 20:09:14 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nXqFF-0002kw-NT for pgsql-hackers@arkaria.postgresql.org; Fri, 25 Mar 2022 20:09:13 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nXqFF-0002kn-F4 for pgsql-hackers@lists.postgresql.org; Fri, 25 Mar 2022 20:09:13 +0000 Received: from relay8-d.mail.gandi.net ([217.70.183.201]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nXqFC-00069P-P9 for pgsql-hackers@lists.postgresql.org; Fri, 25 Mar 2022 20:09:13 +0000 Received: (Authenticated sender: adsend@dunslane.net) by mail.gandi.net (Postfix) with ESMTPSA id 8916F1BF209; Fri, 25 Mar 2022 20:09:06 +0000 (UTC) Message-ID: <7b5c224e-c9c0-fd93-2b51-b399de2d1d4b@dunslane.net> Date: Fri, 25 Mar 2022 16:09:04 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: pgsql: Add 'basebackup_to_shell' contrib module. Content-Language: en-US To: Robert Haas , Andres Freund Cc: PostgreSQL Hackers , Magnus Hagander References: <20220315190428.2xf6klawmaq4nuyy@alap3.anarazel.de> <626827E9-4A50-493D-A8EE-EB3C238BB47F@anarazel.de> From: Andrew Dunstan In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 3/25/22 13:52, Robert Haas wrote: > On Fri, Mar 25, 2022 at 12:36 PM Andres Freund wrote: >> Create a CF entry for it, or enable CI on a github repo? > I created a CF entry for it. Then I had to try to Google around to > find the URL from the cfbot, because it's not even linked from > commitfest.postgresql.org for some reason. #blamemagnus > > I don't think that the Windows CI is running the TAP tests for > contrib. At least, I can't find any indication of it in the output. So > it doesn't really help to assess how portable this test is, unless I'm > missing something. > > I looked through the Linux output. It looks to me like that does run > the TAP tests for contrib. Unfortunately, the output is not in order > and is also not labelled, so it's hard to tell what output goes with > what contrib module. I named my test 001_basic.pl, but there are 12 of > those already. I see that 13 copies of 001_basic.pl seem to have > passed CI on Linux, so I guess the test ran and passed there. It seems > like it would be an awfully good idea to mention the subdirectory name > before each dump of output. Duplication of TAP test names has long been something that's annoyed me. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com