Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r00p9-002f12-EB for pgsql-committers@arkaria.postgresql.org; Mon, 06 Nov 2023 14:43:31 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1r00p7-00GME8-SP for pgsql-committers@arkaria.postgresql.org; Mon, 06 Nov 2023 14:43:29 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r00p7-00GMDy-H9 for pgsql-committers@lists.postgresql.org; Mon, 06 Nov 2023 14:43:29 +0000 Received: from mail-qt1-x832.google.com ([2607:f8b0:4864:20::832]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1r00p4-00513p-8L for pgsql-committers@lists.postgresql.org; Mon, 06 Nov 2023 14:43:28 +0000 Received: by mail-qt1-x832.google.com with SMTP id d75a77b69052e-41cc535cd5cso28964161cf.2 for ; Mon, 06 Nov 2023 06:43:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dunslane-net.20230601.gappssmtp.com; s=20230601; t=1699281804; x=1699886604; darn=lists.postgresql.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/Tw/m8ao1ickPS+OxRJkPYbvjf5QPYtFTXqLKwok52M=; b=Xq3LIrR9Kz/Qs9pAb6xgfrqNdg/oTdJDR7R0L6Xqi/mIS3icvcajqKWZq1AzZF9PCb 14Gdc7pv0duZ8PCirZ433oib2jMfLvJb20czfCyGIbiCZMucfGFEekyGriFhNphtgFVX 2itSt3bs1o+UThHtefNECmqgEWo5dDNBWt3sctiqqeSa6lWw3m4kfPCUw2XGMtTTXBOH YLkOrGEl9Y71mLgHuZ1PZn3Swq4xj8kg+fXhi2QkhRiPpCAkxo0RBo1/u9N818pQjSef dOECphdm7RzxUni1gK6w2KU2tS6tOBBRf31+wIztN6laLfBAJy7cJyU+CFQOy8y9sGAQ CyMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699281804; x=1699886604; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/Tw/m8ao1ickPS+OxRJkPYbvjf5QPYtFTXqLKwok52M=; b=Dkji7MVc+8NTHVM2KE6LihLOzjQRM2r0my2odlTSfptqLuiH1+3Sgmbq0+AXeHFMnM 7Znf5goE1ApXC5rgPRbFjZVtKXsyOdfxb2wBPWbRojd6iHfVgAb51nKVCAGoLEYuyqFT iZ7pJuvBYzqRrmHK3YElawp5WdyLy8FLg4NBXkMfX7kDOmLYG3R+Fyz+eFg3yK8+wz5F z4GvkPDq3pFuyvuvNyyvUXAbfQNeN49MngI+OLSJe7/d/BHxQ5luKguKipaCJbipyuw+ RTcaNk1WRCd42C5bAmTYuLv3laQftEoMWwgNrEjt4+cbpR2i6wOlG2CXh5PdN5sdMcyB xoVg== X-Gm-Message-State: AOJu0Yw8RjgqRLQ7zVZtaBLoD2kf7Aj/Xq6vo8h1W0NTgjdzeCP26D45 +/TqDeKrKgkjIYeZ21i4Er+uaA== X-Google-Smtp-Source: AGHT+IF1NvJ6tsXbsfOHb0v7IrOnLorhiFd5ycnZKVFh4UPOnkuEYowPnM8MhsCP+Mb2vmIyOFR1jg== X-Received: by 2002:a05:6214:d6f:b0:65a:fc2a:c2ab with SMTP id 15-20020a0562140d6f00b0065afc2ac2abmr32979634qvs.49.1699281803858; Mon, 06 Nov 2023 06:43:23 -0800 (PST) Received: from ?IPV6:2605:a601:9122:d800::2bb? ([2605:a601:9122:d800::2bb]) by smtp.googlemail.com with ESMTPSA id f5-20020a0cbec5000000b00641899958efsm3466062qvj.130.2023.11.06.06.43.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Nov 2023 06:43:23 -0800 (PST) Message-ID: <7b8a9460-5668-b372-04e6-7b52e9308493@dunslane.net> Date: Mon, 6 Nov 2023 09:43:21 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: pgsql: Migrate logical slots to the new node during an upgrade. Content-Language: en-US To: Peter Eisentraut , Amit Kapila , pgsql-committers@lists.postgresql.org References: From: Andrew Dunstan In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2023-11-06 Mo 05:31, Peter Eisentraut wrote: > On 26.10.23 04:14, Amit Kapila wrote: >> Migrate logical slots to the new node during an upgrade. > > Something in this patch is causing the pg_upgrade test to be run in > the source directory and leaving files such as delete_old_cluster.sh > around there.  (This is under meson; there shouldn't be any new files > appearing in the source directory during the build.)  Check please. > > > The same probably applies to VPATH builds using Makefiles. 002_pg_upgrade.pl has this, which I think should cure the new script: # In a VPATH build, we'll be started in the source directory, but we want # to run pg_upgrade in the build directory so that any files generated finish # in it, like delete_old_cluster.{sh,bat}. chdir ${PostgreSQL::Test::Utils::tmp_check}; cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com