Message-ID: <7d8d5d1c-f8bd-4570-9db9-90ca5e15b6ec@iki.fi>
Date: Wed, 1 Jan 2025 23:57:23 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: pgsql: Replace BackendIds with 0-based ProcNumbers
To: Peter Eisentraut <peter@eisentraut.org>,
 pgsql-committers@lists.postgresql.org
References: <E1rgpoS-001uTO-3C@gemulon.postgresql.org>
 <bd04d675-4672-4f87-800a-eb5d470c15fc@eisentraut.org>
Content-Language: en-US
From: Heikki Linnakangas <hlinnaka@iki.fi>
In-Reply-To: <bd04d675-4672-4f87-800a-eb5d470c15fc@eisentraut.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/7d8d5d1c-f8bd-4570-9db9-90ca5e15b6ec%40iki.fi>
Precedence: bulk

On 29/12/2024 19:43, Peter Eisentraut wrote:
> On 03.03.24 18:39, Heikki Linnakangas wrote:
>> Replace BackendIds with 0-based ProcNumbers
> 
> There are a couple of declarations that are duplicated between src/ 
> include/storage/proc.h and src/include/storage/procnumber.h, such as 
> MyProcNumber, ParallelLeaderProcNumber, and 
> ProcNumberForTempRelations().  Is that intentional, or should that be 
> fixed?

It was not intentional. At quick glance, I think we should keep the 
declarations in procnumber.h and remove the duplicates from proc.h. I 
will do that next week when I'm back from vacation. Or feel free to do 
it yourself before that if you want. Thanks for noticing!

- Heikki