Content-Type: multipart/alternative;
 boundary="------------ZWDxNUmQBhX1qDC2M5OHOy7T"
Message-ID: <7dc78fd9-0afc-484e-bcba-c6f58567ab81@dunslane.net>
Date: Tue, 1 Apr 2025 17:08:49 -0400
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: TEMP_CONFIG vs test_aio
To: Andres Freund <andres@anarazel.de>, Todd Cook <cookt@blackduck.com>
Cc: "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>,
 Noah Misch <noah@leadboat.com>
References: <E1tzglG-0029Xu-0h@gemulon.postgresql.org>
 <zh5u22wbpcyfw2ddl3lsvmsxf4yvsrvgxqwwmfjddc4c2khsgp@gfysyjsaelr5>
 <EF3AA62E-A317-4A6B-BA98-C03E7238A671@blackduck.com>
 <4fi62oxjougycbzfuynokg2gajxx3j4ue6velmbzgtski5jlpz@72ri5hvlntac>
From: Andrew Dunstan <andrew@dunslane.net>
Content-Language: en-US
Autocrypt: addr=andrew@dunslane.net; keydata=
 xsBNBE7KWFkBCAClridxur2AIc7eW2AR7izbfp3EnNefie2HbLF0izW5Ik5UjX2HBXBx4syI
 gY6b0ugohXrr274+baoAlvSbq6cAoQuEVrk5IZFzt20b1Xkx65FwGSEj526yiKLocqkJceSq
 Xr9xcA5SGY+FZv441chh5SU92v4q6z+6LPpoHOh97ptAVXZYNTtU0LevyvD5lja0TzbvJm6C
 eFXitJfnm1pLEr0DGJCR/iUOl/N62Kh4855zZC7NHIjQHPOvV5Stz/l5ilDhvGVk+xkXFPys
 SjZoUr1rXhYLpiyi5sR0X9FHXT0KnGuz1F5ERO7ZTLSSQ6fJwPj6gOk9K+vvoKvoeql5ABEB
 AAHNJEFuZHJldyBEdW5zdGFuIDxhbmRyZXdAZHVuc2xhbmUubmV0PsLAmwQTAQgARQIbAwIX
 gAIZAQULCQgHAgMiAgEGFQoJCAsCBBYCAwECHgcWIQTkPlhGHfx8v0RpFaWZ+n/LWfw7gQUC
 ZFlxxwUJGVGAbgAKCRCZ+n/LWfw7gXikB/9ZdcUy6CTBFIIuL/bVsc1eLEW/gJBjJBF6HxNY
 xgEkAgXAp4Lg4A5U+QB9GouFr7+GYxF0BU4hzoGhNPUWltxnHdMWP8nC/38LAqgMi8L/bbsm
 HW5YPBdWYaAZAPJQVfOAgjTbRUb26KSprpyrrJKW0ZmrZfjhNPcQ72jpWzoPLQqx2X6B0fru
 1jq+cBh8lb6r1mJTim1T3JIn+F/v5VpdQS+EL8xqsHkfzKjIPsW3CIXpkypSk6saA55Rkkbl
 26AW8ftPVB0Q6Lnn6FLt9CP0MGNixBQ55yq8r1K+nCBvCCjvQjM8RDm0UUum0WNl+ifQgTLO
 E8TWEnwVtkBf+3QWzsBNBE7KWFkBCADRnOM0FCzsYW6jtncg+dWIagjUZpvaClmqn/sJluLa
 Q3v1VXMQJzYs3eC1gh386W+XBwLRpDj3jzH81lX+p73Re3d3oJW7X+ffsxuzu5ZVdMUkqBYo
 nkAbKxr6gyJ12F/+JkUVzLcoTN+d/7YsQvUVi7NaKH8mJgjz112O4fUe3p9wfAaFa0RXHc5S
 GPzRTYRRlv/XZBIho4J2tkZOnteZJZ+GbxQVlINt6fd8P6al3MWOvpP/ExJPguEfjOsO6Njy
 xjo3WfpD4lHMOR/Oc3/8mScEF84rF2jXbsFgelWnbPWAvXY+pD0dXOFRkagGmC/viwBDqq5b
 5tk76kKmUbZxABEBAAHCwHwEGAEIACYCGwwWIQTkPlhGHfx8v0RpFaWZ+n/LWfw7gQUCZFlx
 5wUJGVGAjgAKCRCZ+n/LWfw7gf+iB/4g8CPY5jihf5r/8EsoIGe2H+dpVmpPF8YGBzTIvCz/
 fQoOq8AX/pE76QEuFnFZWfjw+wgBXgCVmkox2Eflkk6z4ND3pcwGZ6CfCxTQCDk/dij+2DQ4
 6bmDCy/sBgcbz9mTpoLC11HLoPae6YN9nBNQRZDcEFEu54OaVOqlIdbA6m+POIBCXZdHOFc0
 WoDTgxHRzC1jgQNidyd6tKqcsVJs0dzF0oKTmFFmUAqTdJO12LBuNA1rlqrR3EtpYk8B/wtS
 5dIMD7Q8hwQpL+4C6GNpb6ZKnPkLi47pDOLhz2qBrqN+rqUEsT3YnExYpzj5yOBi+FlmV1Hw
 49QYe1sn2ZPs
In-Reply-To: <4fi62oxjougycbzfuynokg2gajxx3j4ue6velmbzgtski5jlpz@72ri5hvlntac>
Archived-At: 
 <https://www.postgresql.org/message-id/7dc78fd9-0afc-484e-bcba-c6f58567ab81%40dunslane.net>
Precedence: bulk

This is a multi-part message in MIME format.
--------------ZWDxNUmQBhX1qDC2M5OHOy7T
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit


On 2025-04-01 Tu 4:17 PM, Andres Freund wrote:
> Hi,
>
> On 2025-04-01 20:12:29 +0000, Todd Cook wrote:
>> On 4/1/25, 3:42 PM, "Andres Freund" <andres@anarazel.de <mailto:andres@anarazel.de>> wrote:
>>> I just committed the tests for AIO, and unfortunately they (so far) fail on
>>> one buildfarm animal:
>>> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=bumblebee&dt=2025-04-01%2018%3A55%3A01 <https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=bumblebee&amp;dt=2025-04-01%2018%3A55%3A01>
>>>
>>> The reason for the failure is simple, the buildfarm animal specifies
>>> io_method=io_uring (thanks to "cookt" for setting that up so quickly, whoever
>>> you are :)) and the test is assuming that the -c io_method=... it passes to
>>> initdb is actually going to be used, but it's overwritten by the TEMP_CONFIG.
>> You're welcome!
>>
>> Is there an alternate way I could use to configure the io_method on bumblebee?
> You could use PG_TEST_INITDB_EXTRA_OPTS, but I think you did it the right
> way.
>
> For one using PG_TEST_INITDB_EXTRA_OPTS would probably require changing the
> buildfarm code, because the buildfarm code filters out environment variables
> that aren't on an allowlist (I really dislike that).


Uh, not quite. Anything in the config's build_env is not filtered out. 
That change was made a year ago.


cheers


andrew

--
Andrew Dunstan
EDB:https://www.enterprisedb.com

--------------ZWDxNUmQBhX1qDC2M5OHOy7T
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 7bit

<!DOCTYPE html>
<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body>
    <p><br>
    </p>
    <div class="moz-cite-prefix">On 2025-04-01 Tu 4:17 PM, Andres Freund
      wrote:<br>
    </div>
    <blockquote type="cite"
cite="mid:4fi62oxjougycbzfuynokg2gajxx3j4ue6velmbzgtski5jlpz@72ri5hvlntac">
      <pre wrap="" class="moz-quote-pre">Hi,

On 2025-04-01 20:12:29 +0000, Todd Cook wrote:
</pre>
      <blockquote type="cite">
        <pre wrap="" class="moz-quote-pre">On 4/1/25, 3:42 PM, "Andres Freund" &lt;<a class="moz-txt-link-abbreviated" href="mailto:andres@anarazel.de">andres@anarazel.de</a> <a class="moz-txt-link-rfc2396E" href="mailto:andres@anarazel.de">&lt;mailto:andres@anarazel.de&gt;</a>&gt; wrote:
</pre>
        <blockquote type="cite">
          <pre wrap="" class="moz-quote-pre">I just committed the tests for AIO, and unfortunately they (so far) fail on
one buildfarm animal:
<a class="moz-txt-link-freetext" href="https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=bumblebee&amp;dt=2025-04-01%2018%3A55%3A01">https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=bumblebee&amp;dt=2025-04-01%2018%3A55%3A01</a> <a class="moz-txt-link-rfc2396E" href="https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=bumblebee&amp;amp;dt=2025-04-01%2018%3A55%3A01">&lt;https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=bumblebee&amp;amp;dt=2025-04-01%2018%3A55%3A01&gt;</a>

The reason for the failure is simple, the buildfarm animal specifies
io_method=io_uring (thanks to "cookt" for setting that up so quickly, whoever
you are :)) and the test is assuming that the -c io_method=... it passes to
initdb is actually going to be used, but it's overwritten by the TEMP_CONFIG.
</pre>
        </blockquote>
        <pre wrap="" class="moz-quote-pre">
You're welcome!

Is there an alternate way I could use to configure the io_method on bumblebee?
</pre>
      </blockquote>
      <pre wrap="" class="moz-quote-pre">
You could use PG_TEST_INITDB_EXTRA_OPTS, but I think you did it the right
way.

For one using PG_TEST_INITDB_EXTRA_OPTS would probably require changing the
buildfarm code, because the buildfarm code filters out environment variables
that aren't on an allowlist (I really dislike that).</pre>
    </blockquote>
    <p><br>
    </p>
    <p>Uh, not quite. Anything in the config's build_env is not filtered
      out. That change was made a year ago.<br>
    </p>
    <p><br>
    </p>
    <p>cheers</p>
    <p><br>
    </p>
    <p>andrew<br>
    </p>
    <p><span style="white-space: pre-wrap">
</span></p>
    <pre class="moz-signature"
    signature-switch-id="d0437855-2267-4610-80b3-83167ec45b0b" cols="72">--
Andrew Dunstan
EDB: <a class="moz-txt-link-freetext" href="https://www.enterprisedb.com">https://www.enterprisedb.com</a>
</pre>
  </body>
</html>

--------------ZWDxNUmQBhX1qDC2M5OHOy7T--