Subject: Re: pgsql: Give a better error for duplicate entries in
 VACUUM/ANALYZE colu
To: Tom Lane <tgl@sss.pgh.pa.us>
References: <E1dv9jI-0006oT-Fn@gemulon.postgresql.org>
 <862733d5-f132-a59b-7afb-86002f946f80@2ndquadrant.com>
 <14181.1506366549@sss.pgh.pa.us>
Cc: pgsql-committers@postgresql.org
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Organization: 2ndQuadrant
Message-ID: <7eb88e2f-a6c9-82b3-6add-7794cf6197e9@2ndquadrant.com>
Date: Mon, 25 Sep 2017 16:50:53 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0)
 Gecko/20100101 Thunderbird/52.3.0
MIME-Version: 1.0
In-Reply-To: <14181.1506366549@sss.pgh.pa.us>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk
Sender: pgsql-committers-owner@postgresql.org

On 9/25/17 15:09, Tom Lane wrote:
> Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
>> On 9/21/17 18:13, Tom Lane wrote:
>>> Give a better error for duplicate entries in VACUUM/ANALYZE column list.
> 
>> In the error message, we should write "specified more than once" instead
>> of "specified twice", because that could otherwise look a bit silly:
>> VACUUM ANALYZE vaccluster(i,i,i);
>> ERROR:  column "i" of relation "vaccluster" is specified twice
> 
> OK.
> 
>> (Also, the "is" doesn't seem to fit there.)
> 
> Hm, reads fine to me, and I'd still rather include "is" in the
> revised wording.  Anybody else agree with Peter's wording?

Note a big deal.  I'm just working off existing error messages:

msgid "parameter \"%s\" specified more than once"
msgid "column name \"%s\" specified more than once"
msgid "column \"%s\" specified more than once"
msgid "filter variable \"%s\" specified more than once"
msgid "option \"%s\" provided more than once"
msgid "parameter name \"%s\" used more than once"
msgid "storage type specified more than once"
msgid "procedure number %d for (%s,%s) appears more than once"
msgid "operator number %d for (%s,%s) appears more than once"
msgid "publication name \"%s\" used more than once"
msgid "relation \"%s\" would be inherited from more than once"
msgid "column \"%s\" appears more than once in partition key"
msgid "column name \"%s\" appears more than once in USING clause"
msgid "common column name \"%s\" appears more than once in left table"
msgid "common column name \"%s\" appears more than once in right table"
msgid "WITH query name \"%s\" specified more than once"
msgid "recursive reference to query \"%s\" must not appear more than once"
msgid "XML attribute name \"%s\" appears more than once"
msgid "argument name \"%s\" used more than once"
msgid "table name \"%s\" specified more than once"

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers