Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1uPTiv-008pbe-3n for pgsql-committers@arkaria.postgresql.org; Wed, 11 Jun 2025 22:15:09 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1uPTis-007ERO-6C for pgsql-committers@arkaria.postgresql.org; Wed, 11 Jun 2025 22:15:06 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1uPTir-007ERF-Uv for pgsql-committers@lists.postgresql.org; Wed, 11 Jun 2025 22:15:06 +0000 Received: from mail-pl1-x635.google.com ([2607:f8b0:4864:20::635]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1uPTip-001V6u-2R for pgsql-committers@lists.postgresql.org; Wed, 11 Jun 2025 22:15:05 +0000 Received: by mail-pl1-x635.google.com with SMTP id d9443c01a7336-236377f00easo4357575ad.1 for ; Wed, 11 Jun 2025 15:15:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=j-davis-com.20230601.gappssmtp.com; s=20230601; t=1749680103; x=1750284903; darn=lists.postgresql.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=jr+Q9ReosXXca4G750894vw2I3tA5zUGNKk0/Ky0ST4=; b=wVGttLbc/LbMMfO1L0QZSB71cWGUMs7xp6+DPcyNzw1t3+9NPJhvVpRQpf+jeI6aDD s5P4kqvvLdQcRfKa8sMY84jB7TC6OFin7TlYS98OuMArUWlHtLjXMncn5jMujlt5NDgA ivTOfwh6AJkqx+ACKVwcIgqde7iw+oT1x0c+1wmnxt7BIKJuXUBEIbbplzqgIzIG8XKk NnSTtfPJQFQ96QHwihRUfW3hzLr8ysq5crqZWiG7V9a5d6/Cd/8VB3FW1a+ZRl/TzRYE 6Votrmz2t9oJ+Rn5cvRuSsCTk9P0oe5W1+zxqV04cCIlsBDmpU7OVNFlXxlfCcH9Jl+l c8MQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749680103; x=1750284903; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=jr+Q9ReosXXca4G750894vw2I3tA5zUGNKk0/Ky0ST4=; b=D8xcffrrcRgOnr+e53/a/jBSyjdQS8l8bt/MFHN6ExXULNyxg4phfDJlYg4EOQxxSW fRVccACXmfvtuBI1JG0BiZ3+nVafoRXK/hazlYwl6SPmkIQ1bsETbZ4HXy9jqieOw9oI 5/SX8q3RqjEM7kDs+9LF6n7QFbut03w7wrrnh0b2FNeeAG2C/6NumGMcGyHf+pwPEvEr UE3M4Yd5i0Awt66KI3XadXjuAtSNkmW+bMNwXeajQKVuVg8laCrBzHmR+bEBN4SNsydl MttNSJobkRjhaCmKRcLmEU7o62c1usuAwpG8d0QTQdlV7RzRt6M9ll57U5U29t7Wggd2 xtCA== X-Gm-Message-State: AOJu0YzOOttfStoY52P14GxfmAb05p2QSbZeL2qGDmJe18JdYKbMI0lT oX6UsmYxUhd//UgQKfirz2DqtohcBbkKbWC1vV8DityJishDFlx55HEuOnC+mcWcMQ== X-Gm-Gg: ASbGncvuAXpJDgnfNGV6j6twCfHgKogurye18ZQYSjQSY29W37z+AozQtEsSVRdxAZS 6GgnkCLomdzC6FrvPXcGX9DmNGsDT6T7A8cbtOaJj+iFluNkBG2PSI3Df0+aBzcf5NF4opEx0uX g4H/iYc7M3lnnhplRDYHCY5PNBeynDsXW3z8Rwpyp+hjCWBETchekdcfGXBA+IP6xR9MbZbSnRC NXvpTEQNwm/g9iFH6q+U1jIqS5iY1nQav4Oy+rYR7oj1VIwPt581Fxuxd8h8Z+3H8oftvYNsznf 2/lUs/z/a6gmUXERGqTZ0kQFxMR9nVfukptfWZVTYP9Y2YgQxbUs32T1UdwtXXGwnYaof20fYTh AVeUx1IZ0xxPhNJ2AcZYafgiub4io3dkI X-Google-Smtp-Source: AGHT+IFS/f7uRBQB3vrC4nfy3tHYTlKmDvsbLxp4pqOXBrQUa9mA3j46PPhbWH+x8uA3x2zMQxTdew== X-Received: by 2002:a17:902:cec9:b0:234:d679:72e9 with SMTP id d9443c01a7336-2364c8cd45dmr19843655ad.12.1749680102744; Wed, 11 Jun 2025 15:15:02 -0700 (PDT) Received: from jeff-ws-bridge.lan (c-76-102-242-158.hsd1.ca.comcast.net. [76.102.242.158]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2364e702589sm636665ad.186.2025.06.11.15.15.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Jun 2025 15:15:02 -0700 (PDT) Message-ID: <7efaaa645aa5df3771bb47b9c35df27e08f3520e.camel@j-davis.com> Subject: Re: pgsql: copyfromparse.c: use pg_ascii_tolower() rather than tolower(). From: Jeff Davis To: Robert Haas , Jeff Davis Cc: pgsql-committers@lists.postgresql.org Date: Wed, 11 Jun 2025 15:15:01 -0700 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.52.3-0ubuntu1 MIME-Version: 1.0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Wed, 2025-06-11 at 16:07 -0400, Robert Haas wrote: > All 3 of these commits seem like things that could just as well have > been done after we branch. Yeah, I called out my mistake here: https://www.postgresql.org/message-id/60e8c6d0a6c08e67f15dbbe9e53df0119c710= 065.camel%40j-davis.com Nobody seemed terribly upset about it so I left them. But for the sake of ending any confusion I just reverted them. I will reapply them in a few weeks after the branch. Regards, Jeff Davis