Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nZpKB-0005Ek-5q for pgsql-committers@arkaria.postgresql.org; Thu, 31 Mar 2022 07:34:31 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nZpK9-0006c2-Ti for pgsql-committers@arkaria.postgresql.org; Thu, 31 Mar 2022 07:34:29 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nZpK9-0006bt-MP for pgsql-committers@lists.postgresql.org; Thu, 31 Mar 2022 07:34:29 +0000 Received: from out4-smtp.messagingengine.com ([66.111.4.28]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nZpK6-0000UP-Rx for pgsql-committers@lists.postgresql.org; Thu, 31 Mar 2022 07:34:28 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 2F7595C018C; Thu, 31 Mar 2022 03:34:26 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Thu, 31 Mar 2022 03:34:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:date:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; bh=VWx57KRQSJFtNa/587Y6hGABSRbe7jRA/4GpHZlmPe8=; b=S7yBfosm pM6mKrkpnsabuVzbXqaPzPN7NMRQMdTSkoNJIO+MQO1g06z2SB+5eJYy1Ex0yqyh JkQAHX0JYJ3BFgOWDlpA/hleVvZWbeaIpBbbhET1KwXZ5QqQXqFaHuam4HzzmFWH 1HX9ZX4EoWEoy8DIR1FoFjZP0gRR99xHa0PJQbVN4XnIv8+POlHAkw9U4i/4aDoL FVNhr01+rnnRVcAFpW0yWK3uI6kvq0pdQJMorGGMhzg0EP2D5iKcjTLvYtR6cWcA p7ZeSxP7/yGE7FZy6bxwpWBySTYY8VSaPj463j+N9amR1u3kMtBVdjeOzLgTTSX+ aBQoUwj9Yzn2lA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudeifedgudduhecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhepkfffgggfuffvfhfhjggtgfesth ejredttdefjeenucfhrhhomheprfgvthgvrhcugfhishgvnhhtrhgruhhtuceophgvthgv rhdrvghishgvnhhtrhgruhhtsegvnhhtvghrphhrihhsvggusgdrtghomheqnecuggftrf grthhtvghrnhepfeejgeehteeuhfevveduleeufedtjeetiefftedvudfhtdeifefgueet tdevgefgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh epphgvthgvrhdrvghishgvnhhtrhgruhhtsegvnhhtvghrphhrihhsvggusgdrtghomh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 31 Mar 2022 03:34:25 -0400 (EDT) Message-ID: <7f85ef6d-250b-f5ec-9867-89f0b16d019f@enterprisedb.com> Date: Thu, 31 Mar 2022 09:34:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: pgsql: Allow root-owned SSL private keys in libpq, not only the backend Content-Language: en-US To: Tom Lane , pgsql-committers@lists.postgresql.org References: From: Peter Eisentraut In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 02.03.22 17:57, Tom Lane wrote: > Allow root-owned SSL private keys in libpq, not only the backend. > > This change makes libpq apply the same private-key-file ownership > and permissions checks that we have used in the backend since commit > 9a83564c5. Namely, that the private key can be owned by either the > current user or root (with different file permissions allowed in the > two cases). This allows system-wide management of key files, which > is just as sensible on the client side as the server, particularly > when the client is itself some application daemon. > > Sync the comments about this between libpq and the backend, too. > > Back-patch of a59c79564 and 50f03473e into all supported branches. I think this libpq_gettext("private key file \"%s\" is not a regular file"), should have a trailing newline in the string.