Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qlfYs-003qjU-8X for pgsql-committers@arkaria.postgresql.org; Thu, 28 Sep 2023 01:11:26 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1qlfYq-007Aoo-Bo for pgsql-committers@arkaria.postgresql.org; Thu, 28 Sep 2023 01:11:24 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qlfWC-00793y-Bu for pgsql-committers@lists.postgresql.org; Thu, 28 Sep 2023 01:08:40 +0000 Received: from sss.pgh.pa.us ([68.162.161.243]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qlfW9-0071eH-K1; Thu, 28 Sep 2023 01:08:39 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 38S18aTV802308; Wed, 27 Sep 2023 21:08:36 -0400 From: Tom Lane To: Amit Langote cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Remove obsolete executor cleanup code In-reply-to: References: Comments: In-reply-to Amit Langote message dated "Thu, 28 Sep 2023 01:02:07 -0000" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <802306.1695863316.1@sss.pgh.pa.us> Date: Wed, 27 Sep 2023 21:08:36 -0400 Message-ID: <802307.1695863316@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Amit Langote writes: > After these modifications, the ExecEnd*() routines for ValuesScan, > NamedTuplestoreScan, and WorkTableScan became redundant. So, this > commit removes them. This seems like quite a bad idea. From a documentation standpoint alone, it would be far better for these functions to exist but be empty. regards, tom lane