From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: pgsql-committers@lists.postgresql.org,
        Andrew Dunstan <andrew@dunslane.net>
Subject: Re: pgsql: ecpg: Output dir, source dir,
 stamp file argument for preproc/*.
In-reply-to: <E1oDWqn-000ADD-Oh@gemulon.postgresql.org>
References: <E1oDWqn-000ADD-Oh@gemulon.postgresql.org>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Mon, 18 Jul 2022 19:56:18 -0000"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <819624.1658178872.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Mon, 18 Jul 2022 17:14:32 -0400
Message-ID: <819625.1658178872@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/819625.1658178872%40sss.pgh.pa.us>
Precedence: bulk

Andres Freund <andres@anarazel.de> writes:
> ecpg: Output dir, source dir, stamp file argument for preproc/*.pl

crake says that perlcritic doesn't like this:

Jul 18 16:48:25 ./src/interfaces/ecpg/preproc/parse.pl: Bareword file hand=
le opened at line 30, column 1.  See pages 202,204 of PBP.  ([InputOutput:=
:ProhibitBarewordFileHandles] Severity: 5)
Jul 18 16:48:25 ./src/interfaces/ecpg/preproc/parse.pl: Bareword file hand=
le opened at line 31, column 1.  See pages 202,204 of PBP.  ([InputOutput:=
:ProhibitBarewordFileHandles] Severity: 5)

That's bitching about

open(our $parserfh, '<', $parser) or die "could not open parser file $pars=
er";
open(our $outfh, '>', $outfile) or die "could not open output file $outfil=
e";

which doesn't look like a bareword to my non-perl-monk eye,
but what do I know?  Maybe you should be using "my" instead
of "our", because I don't see anything else about it that looks
different from other places in our code.

			regards, tom lane