Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pa3NP-0002aJ-5g for pgsql-hackers@arkaria.postgresql.org; Wed, 08 Mar 2023 23:39:19 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pa3NN-0000qu-R0 for pgsql-hackers@arkaria.postgresql.org; Wed, 08 Mar 2023 23:39:17 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pa3NN-0000qk-GG for pgsql-hackers@lists.postgresql.org; Wed, 08 Mar 2023 23:39:17 +0000 Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pa3NJ-00020r-AQ for pgsql-hackers@lists.postgresql.org; Wed, 08 Mar 2023 23:39:16 +0000 Received: by mail-wr1-x42e.google.com with SMTP id l1so196770wry.12 for ; Wed, 08 Mar 2023 15:39:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb.com; s=google; t=1678318751; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=3w0rsaty8pNZk7w/OFx4nPuYMim5kUToZS+/MTkvm2g=; b=DqkFOpFS5b5praKbb4SPug11ZA0dFC2hX7Q3ehkGSzhhAOP4FkkEOWXrTJaOS/mKzC B2D/86A+CPEc/dPzl5Fjp1OQhW34c4pcCJdRFSLH9FfsFxa7JooQxqnSli7Z34CUCIob N7TBPsnAssHI+kO/fdnVHEj7jEOlel2+31T+qtPECqNjvoXGM0NtUnkQXrgi7xYIXWLB MNcrFBj/T2ZgpruPDnmifk9m3RXvm/z9ogH68T73/7wiN+dNdz5WYF1mkKDU4PoyU9cD nFCV9zvasCD4ilM6Foz7RSw/ydIhl8wD7ltXs3702Gl3m3dn7KRCR8+edJg9qZFUX5WJ /s3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678318751; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3w0rsaty8pNZk7w/OFx4nPuYMim5kUToZS+/MTkvm2g=; b=5PAHuCs2BnFZH/zklbWAbbh/b/43YQXicSVe9j+PNcNkl4WugqkJQDqW/JP6aLVMdr kHCQdDATjE8ZKCOBP3zrXzw+I5v4OyCUhOMztK4+Gr/QvSmF9Gvii4RLMvyBuCqONhuJ OMzB7VS9fXG1LxE2vSWsekrn6c0FecQPvbhPmHaS4ZBUG8baue7q1O2pjhLtYNt6iauS rU0MairggKfwb9tFveOn0tN3AJ+VJERwcmiB3v/6hrX2bNTz7v2cyxDTBOAqWlJEKZeX Q66VNX3nf9qWYEV4FL+eaix5Jh4DmgFn6qRZaz8TUnG27M1oayrfEeUQihy7FA2oO+wo S4lw== X-Gm-Message-State: AO0yUKUT5LfiROyiX6CzWL4ZyiQGU/c+vCIwam1xKHM/Br3Vt64Km/rA cNwF5lM/640fNf60onBwBvcQtvD7gCXidBBAQ35OLgf69PRsh8d7R2ZbEGGIJBK58WSWhiOE9x4 9WhjZ6XUWH2ryq8cCF6kymsVuifVyCNw9fNVbSU2tNlZk0I7HeOSfpZrM58coysrbdigNJIBfHD g4ORiePPNrRkoQRK4fN7IecVP4s56kfNVMAegDNbs+dk2TTvE8nS5e X-Google-Smtp-Source: AK7set/Kcdj2iwNQOyzI7Q+b3NKMbnOjuqMv3ytih3QLje+f7EXhJIljEMvfJ89m/kAzTFlhWzD6xQ== X-Received: by 2002:a5d:4d49:0:b0:2c6:c9f1:e444 with SMTP id a9-20020a5d4d49000000b002c6c9f1e444mr17950110wru.16.1678318751198; Wed, 08 Mar 2023 15:39:11 -0800 (PST) Received: from [10.137.0.17] (xdsl.62.192.157.70.srvc.fr. [62.192.157.70]) by smtp.gmail.com with ESMTPSA id z4-20020adfd0c4000000b002c5493a17efsm16196416wrh.25.2023.03.08.15.39.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Mar 2023 15:39:10 -0800 (PST) Message-ID: <819f6883-f7cf-74fd-e918-4c06a9d76d0b@enterprisedb.com> Date: Thu, 9 Mar 2023 00:39:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: lz4 --rm on Ubuntu 18.04 (Add LZ4 compression to pg_dump) Content-Language: en-US To: Daniel Gustafsson , Christoph Berg Cc: Tomas Vondra , PostgreSQL Hackers References: From: Tomas Vondra In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 3/8/23 20:20, Daniel Gustafsson wrote: >> On 8 Mar 2023, at 18:55, Christoph Berg wrote: > >> 18.04 will be EOL in a few weeks so it might be ok to just say it's >> not supported, but removing the input file manually after calling lz4 >> would be an easy fix. > > Is it reasonable to expect that this version of LZ4 can/will appear on any > other platform outside of archeology? Removing the file manually would be a > trivial way to stabilize but if it's only expected to happen on platforms which > are long since EOL by the time 16 ships then the added complication could be > hard to justify. > IMO we should fix that. We have a bunch of buildfarm members running on Ubuntu 18.04 (or older) - it's true none of them seems to be running TAP tests. But considering how trivial the fix is ... Barring objections, I'll push a fix early next week. regards -- Tomas Vondra EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company