Content-Type: multipart/mixed; boundary="------------Ls82bFjXdLenb16PnYNl7DDt"
Message-ID: <81b84b74-01ad-4782-9114-86ff842b1fd7@postgrespro.ru>
Date: Fri, 26 Apr 2024 17:38:53 +0300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: pgsql: psql: add an optional execution-count limit to \watch.
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>,
 Alexander Korotkov <aekorotkov@gmail.com>,
 Andrew Dunstan <andrew@dunslane.net>,
 Aleksander Alekseev <aleksander@timescale.com>
References: <E1pkTFl-001hzA-LR@gemulon.postgresql.org>
 <CAPpHfdv+10Uk6FWjsh3+ju7kHYr76LaRXbYayXmrM7FBU-=Hgg@mail.gmail.com>
 <2929174.1680876023@sss.pgh.pa.us>
 <CAPpHfdtgQVRZOwov-Ei4Rh=gQtFE8Hb9uKkO1d_XYmQ2XEXt0g@mail.gmail.com>
 <CAJ7c6TO9KpYYxoVVseWEQB5KtjWDkt8NfyAeKPcHoe2Jq+ykpw@mail.gmail.com>
 <4032363.1681134882@sss.pgh.pa.us>
 <CAJ7c6TOFPoHVSxaQXfbm38_QN1v4qaugZW0LBTB-Gkvk2UwBQw@mail.gmail.com>
 <4076950.1681139381@sss.pgh.pa.us>
 <CAJ7c6TOVFT0bOEunovQAmZJDiLJ7Dds4YSONi4yOS1GYLvNntA@mail.gmail.com>
 <2748103.1681839252@sss.pgh.pa.us>
 <5ed7d3e2-ca7e-40ad-9de9-e7648576cc01@postgrespro.ru>
 <4051932.1714098047@sss.pgh.pa.us>
Content-Language: en-US
From: Anton Voloshin <a.voloshin@postgrespro.ru>
In-Reply-To: <4051932.1714098047@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/81b84b74-01ad-4782-9114-86ff842b1fd7%40postgrespro.ru>
Precedence: bulk

This is a multi-part message in MIME format.
--------------Ls82bFjXdLenb16PnYNl7DDt
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 26/04/2024 05:20, Tom Lane wrote:
> Haven't we worked around that everywhere it matters, in commits such
> as 8421f6bce and 605062227?

Yes, needing 8421f6bce and 605062227 was, perhaps, surprising, but 
reasonable. Unlike breaking floating point constants in the source code. 
But, I guess, you're right and, since it does look like a Perl bug, 
we'll have to work around that in all places where we use floating-point 
constants in Perl code, which are surprisingly few.

 > For me, check-world passes under
 > LANG=ru_RU, even with perl 5.38.2 (where I do confirm that your
 > test script fails).  The buildfarm isn't unhappy either.

Indeed, check-world seems to run fine on my machine and on the bf as well.

Grepping and browsing through, I've only found three spots with \d\.\d 
directly in Perl code as a float, only one of them needs correction.

1. src/test/perl/PostgreSQL/Test/Kerberos.pm in master
src/test/kerberos/t/001_auth.pl in REL_16_STABLE
 >     if ($krb5_version >= 1.15)

I guess adding use locale ':numeric' would be easiest workaround here.
Alternatively, we could also split version into krb5_major_version and 
krb5_minor_version while parsing krb5-config --version's output above, 
but I don't think that's warranted. So I suggest something along the 
lines of 0001-use-numeric-locale-in-kerberos-test-rel16.patch and 
*-master.patch (attached, REL_16 and master need this change in 
different places).

I did verify by providing fake 'krb5-config' that before the fix, with 
LANG=ru_RU.UTF-8 and Perl 5.38.2 and with, say, krb5 "version" 1.13 it 
would still add the "listen" lines to kdc.conf by mistake (presumably, 
confusing some versions of kerberos).

2 and 3. contrib/intarray/bench/create_test.pl
 >     if (rand() < 0.7)
and
 >     if ($#sect < 0 || rand() < 0.1)

PostgreSQL::Test::Utils is not used there, so it's OK, no change needed.

I did not find any other float constants in .pl/.pm files in master (I 
could have missed something).

 > Particularly in
 > this way --- what are we supposed to do, write "if (0 < 0,5)"?
 > That means something else.

Yep. I will try to report this to Perl community later.

-- 
Anton Voloshin
Postgres Professional, The Russian Postgres Company
https://postgrespro.ru
--------------Ls82bFjXdLenb16PnYNl7DDt
Content-Type: text/x-patch; charset=UTF-8;
 name="0001-use-numeric-locale-in-kerberos-test-rel16.patch"
Content-Disposition: attachment;
 filename="0001-use-numeric-locale-in-kerberos-test-rel16.patch"
Content-Transfer-Encoding: base64

RnJvbSBiYzE4N2NkOTVmOTFkNWE3ZmU5N2JhNGNjZmFmNzViNzdlMmYwM2M4IE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBBbnRvbiBWb2xvc2hpbiA8YS52b2xvc2hpbkBwb3N0
Z3Jlc3Byby5ydT4KRGF0ZTogRnJpLCAyNiBBcHIgMjAyNCAxMjoyNDo0OSArMDAwMApTdWJq
ZWN0OiBbUEFUQ0hdIHVzZSBudW1lcmljIGxvY2FsZSBpbiBrZXJiZXJvcyB0ZXN0IHRvIHdv
cmsgYXJvdW5kIHBlcmwgYnVnCgpBZnRlciBiMTI0MTA0ZTcgd2UgYmVjYW1lIHN1c2NlcHRp
YmxlIHRvIFBlcmwgYnVnIChhdCBsZWFzdCBvbiBQZXJsCjUuMzguMiksIHdoZXJlIG9uIGxv
Y2FsZXMgd2l0aCBub24tZG90IGZyYWN0aW9uYWwgcGFydCBzZXBhcmF0b3IsCmZsb2F0aW5n
LXBvaW50IGNvbnN0YW50cyBpbiBwZXJsIHNvdXJjZSBhcmUgYnJva2VuICgxLjE1IHdvdWxk
IGJlICcxJykuCldvcmsgYXJvdW5kIHRoYXQgYnkgdXNpbmcgbnVtZXJpYyBsb2NhbGUgaW4g
dGhpcyBmaWxlLgotLS0KIHNyYy90ZXN0L2tlcmJlcm9zL3QvMDAxX2F1dGgucGwgfCAyICsr
CiAxIGZpbGUgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvc3JjL3Rl
c3Qva2VyYmVyb3MvdC8wMDFfYXV0aC5wbCBiL3NyYy90ZXN0L2tlcmJlcm9zL3QvMDAxX2F1
dGgucGwKaW5kZXggZDc0ZTRhZjQ2NGUuLjk0NzVmMTRkNTBlIDEwMDY0NAotLS0gYS9zcmMv
dGVzdC9rZXJiZXJvcy90LzAwMV9hdXRoLnBsCisrKyBiL3NyYy90ZXN0L2tlcmJlcm9zL3Qv
MDAxX2F1dGgucGwKQEAgLTIzLDYgKzIzLDggQEAgdXNlIFBvc3RncmVTUUw6OlRlc3Q6OlV0
aWxzOwogdXNlIFBvc3RncmVTUUw6OlRlc3Q6OkNsdXN0ZXI7CiB1c2UgVGVzdDo6TW9yZTsK
IHVzZSBUaW1lOjpIaVJlcyBxdyh1c2xlZXApOworIyBXb3JrIGFyb3VuZCB0aGUgUGVybCA1
LjM4LjIgYnVnOiB3ZSBuZWVkIGZsb2F0aW5nLXBvaW50IGNvbnN0YW50cy4KK3VzZSBsb2Nh
bGUgJzpudW1lcmljJzsKIAogaWYgKCRFTlZ7d2l0aF9nc3NhcGl9IG5lICd5ZXMnKQogewot
LSAKMi40My4wCgo=
--------------Ls82bFjXdLenb16PnYNl7DDt
Content-Type: text/x-patch; charset=UTF-8;
 name="0001-use-numeric-locale-in-kerberos-test-master.patch"
Content-Disposition: attachment;
 filename="0001-use-numeric-locale-in-kerberos-test-master.patch"
Content-Transfer-Encoding: base64

RnJvbSBkNmVlOWE1NTY3Y2VhNTAzYzIxMWZhNDFhMGY3NDFjNzFhYTYwYWQ1IE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBBbnRvbiBWb2xvc2hpbiA8YS52b2xvc2hpbkBwb3N0
Z3Jlc3Byby5ydT4KRGF0ZTogRnJpLCAyNiBBcHIgMjAyNCAxNDoyMzoyOCArMDAwMApTdWJq
ZWN0OiBbUEFUQ0hdIHVzZSBudW1lcmljIGxvY2FsZSBpbiBrZXJiZXJvcyB0ZXN0IHRvIHdv
cmsgYXJvdW5kIHBlcmwgYnVnCgpBZnRlciBiMTI0MTA0ZTcgd2UgYmVjYW1lIHN1c2NlcHRp
YmxlIHRvIFBlcmwgYnVnIChhdCBsZWFzdCBvbiBQZXJsCjUuMzguMiksIHdoZXJlIG9uIGxv
Y2FsZXMgd2l0aCBub24tZG90IGZyYWN0aW9uYWwgcGFydCBzZXBhcmF0b3IsCmZsb2F0aW5n
LXBvaW50IGNvbnN0YW50cyBpbiBwZXJsIHNvdXJjZSBhcmUgYnJva2VuICgxLjE1IHdvdWxk
IGJlICcxJykuCldvcmsgYXJvdW5kIHRoYXQgYnkgdXNpbmcgbnVtZXJpYyBsb2NhbGUgaW4g
dGhpcyBmaWxlLgotLS0KIHNyYy90ZXN0L3BlcmwvUG9zdGdyZVNRTC9UZXN0L0tlcmJlcm9z
LnBtIHwgMiArKwogMSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdp
dCBhL3NyYy90ZXN0L3BlcmwvUG9zdGdyZVNRTC9UZXN0L0tlcmJlcm9zLnBtIGIvc3JjL3Rl
c3QvcGVybC9Qb3N0Z3JlU1FML1Rlc3QvS2VyYmVyb3MucG0KaW5kZXggZjc4MTBkYTljMWQu
LjJjMjljNjczMjllIDEwMDY0NAotLS0gYS9zcmMvdGVzdC9wZXJsL1Bvc3RncmVTUUwvVGVz
dC9LZXJiZXJvcy5wbQorKysgYi9zcmMvdGVzdC9wZXJsL1Bvc3RncmVTUUwvVGVzdC9LZXJi
ZXJvcy5wbQpAQCAtOSw2ICs5LDggQEAgcGFja2FnZSBQb3N0Z3JlU1FMOjpUZXN0OjpLZXJi
ZXJvczsKIHVzZSBzdHJpY3Q7CiB1c2Ugd2FybmluZ3MgRkFUQUwgPT4gJ2FsbCc7CiB1c2Ug
UG9zdGdyZVNRTDo6VGVzdDo6VXRpbHM7CisjIFdvcmsgYXJvdW5kIHRoZSBQZXJsIDUuMzgu
MiBidWc6IHdlIG5lZWQgZmxvYXRpbmctcG9pbnQgY29uc3RhbnRzLgordXNlIGxvY2FsZSAn
Om51bWVyaWMnOwogCiBvdXIgKCRrcmI1X2Jpbl9kaXIsICRrcmI1X3NiaW5fZGlyLCAka3Ji
NV9jb25maWcsICRraW5pdCwgJGtsaXN0LAogCSAka2RiNV91dGlsLCAka2FkbWluX2xvY2Fs
LCAka3JiNWtkYywKLS0gCjIuNDMuMAoK

--------------Ls82bFjXdLenb16PnYNl7DDt--