Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nEcyh-00028L-PQ for pgsql-committers@arkaria.postgresql.org; Mon, 31 Jan 2022 20:08:43 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nEcya-0005mS-UP for pgsql-committers@arkaria.postgresql.org; Mon, 31 Jan 2022 20:08:36 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nEcya-0005mA-Nt for pgsql-committers@lists.postgresql.org; Mon, 31 Jan 2022 20:08:36 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nEcyY-0008RZ-Gc for pgsql-committers@lists.postgresql.org; Mon, 31 Jan 2022 20:08:35 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 20VK8U70829538; Mon, 31 Jan 2022 15:08:30 -0500 From: Tom Lane To: Andres Freund cc: pgsql-committers@lists.postgresql.org, Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?= Subject: Re: pgsql: plperl: windows: Use Perl_setlocale on 5.28+, fixing compile fai In-reply-to: <20220131020934.g6bfyalgkwnvqugw@alap3.anarazel.de> References: <20220131013548.enc5d6qqyokhmj3q@alap3.anarazel.de> <20220131015130.shn6wr2fzuymerf6@alap3.anarazel.de> <535668.1643594467@sss.pgh.pa.us> <20220131020934.g6bfyalgkwnvqugw@alap3.anarazel.de> Comments: In-reply-to Andres Freund message dated "Sun, 30 Jan 2022 18:09:34 -0800" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <829536.1643659710.1@sss.pgh.pa.us> Date: Mon, 31 Jan 2022 15:08:30 -0500 Message-ID: <829537.1643659710@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Andres Freund writes: > On 2022-01-30 21:01:07 -0500, Tom Lane wrote: >> I think we oughta backport. We didn't do so at the time because >> we thought it was mostly cosmetic/future-proofing, but evidently >> the future is now. >> I can look into that tomorrow or so. > Cool. I can either do a revert of the set of commits just now afterwards, or > you can fold that into the backpatch... Done now. regards, tom lane