Message-ID: <8320cca6-5647-be5d-9b22-914415bcbc27@dunslane.net>
Date: Tue, 11 Jan 2022 16:44:15 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.2.0
Subject: Re: pgsql: Check for STATUS_DELETE_PENDING on Windows.
Content-Language: en-US
To: Thomas Munro <thomas.munro@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>
Cc: Thomas Munro <tmunro@postgresql.org>,
 pgsql-committers <pgsql-committers@lists.postgresql.org>
References: <E1mvWTz-0006Hc-Dn@gemulon.postgresql.org>
 <2760528.1641929756@sss.pgh.pa.us>
 <CA+hUKGLpuR87F7s7GCkCn9Qs0GMyLJYvRYxf_zQJPw==t+uE0g@mail.gmail.com>
From: Andrew Dunstan <andrew@dunslane.net>
In-Reply-To: 
 <CA+hUKGLpuR87F7s7GCkCn9Qs0GMyLJYvRYxf_zQJPw==t+uE0g@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/8320cca6-5647-be5d-9b22-914415bcbc27%40dunslane.net>
Precedence: bulk


On 1/11/22 16:22, Thomas Munro wrote:
> 2. headerscheck and cpluspluscheck don't like it, at least
>> not on non-Windows:
>>
>> $ src/tools/pginclude/headerscheck
>> In file included from /tmp/headerscheck.WKh8cz/test.c:2:
>> ./src/include/port/win32ntdll.h:20:10: fatal error: ntstatus.h: No such file or directory
>>  #include <ntstatus.h>
>>           ^~~~~~~~~~~~
>>
>> One way to solve that, perhaps, is to wrap the whole header
>> in #ifdef WIN32.  But I think our more usual practice has
>> been to add such headers to the exclusion lists in those
>> two scripts.
> Done.
>
> Those scripts aren't really on my radar... would it be a good idea to
> run them as steps in the CompilerWarnings CI task?
>
>


Or in a buildfarm module (c.f. the perl checks)


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com