From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: pgsql-committers@lists.postgresql.org,
        Andrew Dunstan <andrew@dunslane.net>
Subject: Re: pgsql: ecpg: Output dir, source dir,
 stamp file argument for preproc/*.
In-reply-to: <20220718221535.bf43zwf5rf2wi4wd@awork3.anarazel.de>
References: <E1oDWqn-000ADD-Oh@gemulon.postgresql.org>
 <20220718211408.o2uyu5kvud56ihlj@awork3.anarazel.de>
 <822625.1658179641@sss.pgh.pa.us>
 <20220718215042.sl3hivoupdb7lkwv@awork3.anarazel.de>
 <838180.1658181982@sss.pgh.pa.us>
 <20220718221535.bf43zwf5rf2wi4wd@awork3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Mon, 18 Jul 2022 15:15:35 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <840981.1658182844.1@sss.pgh.pa.us>
Date: Mon, 18 Jul 2022 18:20:44 -0400
Message-ID: <840982.1658182844@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/840982.1658182844%40sss.pgh.pa.us>
Precedence: bulk

Andres Freund <andres@anarazel.de> writes:
> On 2022-07-18 18:06:22 -0400, Tom Lane wrote:
>> I took it out and fixed the half-dozen places where I got warnings,
>> as attached.

> Grepping for 'no warnings' shows that check_rules.pl has the same
> issue. Perhaps worth fixing at the same time, given how closely related they
> are?

Ah, I didn't think to look around.  I'll see what I can do there.

>> Seem like a good fix?

> Looks good to my not-perl-trained eyes.

Yeah, I'm more worried about non-idiomatic usage than whether
it works or not.

> Might be worth making sure the output files are the same before / after? You
> probably already checked...

Yup, I did.

			regards, tom lane