Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dwYTz-0002K7-It for pgsql-committers@arkaria.postgresql.org; Mon, 25 Sep 2017 18:51:55 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1dwYTz-0005O7-1Z for pgsql-committers@arkaria.postgresql.org; Mon, 25 Sep 2017 18:51:55 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1dwYTy-0005Nx-K6 for pgsql-committers@postgresql.org; Mon, 25 Sep 2017 18:51:54 +0000 Received: from out1-smtp.messagingengine.com ([66.111.4.25]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1dwYTq-0004hy-TH for pgsql-committers@postgresql.org; Mon, 25 Sep 2017 18:51:53 +0000 Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 4ADC72205D; Mon, 25 Sep 2017 14:51:45 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute7.internal (MEProxy); Mon, 25 Sep 2017 14:51:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=hPHw4AGPyZfgPbTIF6ylrL2gsZT9UAG5f7ip4hD1JmE=; b=Kjw/WXqg 8f9WB9KrOFsLNO9XOY37PimptrWT2BAOp1gorz0PUnHYGjtbYz1NaeFNuw97/OVv dAMT2nMTefE7SUz14haiZY7N5xAqopC72vsLuIDDx3PuuRwWdA4OjvJUE/HogFgh 3GMhSXvskBbsxKWY1wQ46pI1ltYjst4oMOHMviEN/ndN0uIu1thAoS0faR0lX9Tx lpuYifU11xr2PadUhOWD9ptCeZm+ci5QonlvrrU1r3FJFok0NSGj+0qJlIKWNCU/ /NI/Vz++rQBxlsoaHJ5lxOiiJJfAAbdYBVIBnPpesiL7Si9QRO7KLxGFTHHPgVsI BTx6ocHUeykdhw== X-ME-Sender: X-Sasl-enc: K+dKx8hzEiXQtBEb9mDUI11MCXz9N5G2B+P9tkD8CPPI 1506365505 Received: from april.local (c-73-13-66-39.hsd1.pa.comcast.net [73.13.66.39]) by mail.messagingengine.com (Postfix) with ESMTPA id EDAB3248D1; Mon, 25 Sep 2017 14:51:44 -0400 (EDT) Subject: Re: pgsql: Give a better error for duplicate entries in VACUUM/ANALYZE colu To: Tom Lane , pgsql-committers@postgresql.org References: From: Peter Eisentraut Organization: 2ndQuadrant Message-ID: <862733d5-f132-a59b-7afb-86002f946f80@2ndquadrant.com> Date: Mon, 25 Sep 2017 14:51:44 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-committers Precedence: bulk Sender: pgsql-committers-owner@postgresql.org On 9/21/17 18:13, Tom Lane wrote: > Give a better error for duplicate entries in VACUUM/ANALYZE column list. > > Previously, the code didn't think about this case and would just try to > analyze such a column twice. In the error message, we should write "specified more than once" instead of "specified twice", because that could otherwise look a bit silly: VACUUM ANALYZE vaccluster(i,i,i); ERROR: column "i" of relation "vaccluster" is specified twice (Also, the "is" doesn't seem to fit there.) -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-committers