Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oBgqa-0001Sf-Pl for pgsql-committers@arkaria.postgresql.org; Wed, 13 Jul 2022 18:12:28 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oBgqZ-0003KJ-Lx for pgsql-committers@arkaria.postgresql.org; Wed, 13 Jul 2022 18:12:27 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oBgqZ-0003Jy-EO for pgsql-committers@lists.postgresql.org; Wed, 13 Jul 2022 18:12:27 +0000 Received: from out3-smtp.messagingengine.com ([66.111.4.27]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oBgqX-0000Sn-0v for pgsql-committers@lists.postgresql.org; Wed, 13 Jul 2022 18:12:26 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 708CD5C00F3; Wed, 13 Jul 2022 14:12:24 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Wed, 13 Jul 2022 14:12:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:date:feedback-id:feedback-id:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to:x-me-proxy:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; t=1657735944; x=1657822344; bh=5 BbdyueXYjUkWqFY7bKhn6MiJ1Ib8/r0hGRt3MhoFdo=; b=v20M1aW2evFPQd3cp V6xcXYOQ+/q07iExpkcmYO9aZoxR2qcr24pzBVyij5FiDDPw5vYpUEyIOUjD91zW L+US/5DnsAAawS9pX/nkDYzmyPfqsTmla7gEe5jxgwfW7d/oSVg8w2/gdWDSGUoZ b+rpTxib9zDyE1PDF0g+sBSxJf7MXRZ4HzTmHVKl3/I/srbHJMCPwWBBuZMg5kVl oFTss32t4qGBXVznGK60RAxmj+dEYrOTDUFjIaBi8MIN8PQrHCSzjMbuOnu3c1Ox 6M2mJ0ZF3Hl1m5ThiwRd0f8a07ST5vp3N4gEiWeVcp0u4qsgsMpbhBZwBU1SKUhV OY5pA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudejjedguddvudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhepkfffgggfuffvfhfhjggtgfesth ejredttdefjeenucfhrhhomheprfgvthgvrhcugfhishgvnhhtrhgruhhtuceophgvthgv rhdrvghishgvnhhtrhgruhhtsegvnhhtvghrphhrihhsvggusgdrtghomheqnecuggftrf grthhtvghrnhepfeejgeehteeuhfevveduleeufedtjeetiefftedvudfhtdeifefgueet tdevgefgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh epphgvthgvrhdrvghishgvnhhtrhgruhhtsegvnhhtvghrphhrihhsvggusgdrtghomh X-ME-Proxy: Feedback-ID: i131946ab:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 13 Jul 2022 14:12:23 -0400 (EDT) Message-ID: <864b47bd-6e82-2d02-070d-ae5076d8c4c1@enterprisedb.com> Date: Wed, 13 Jul 2022 20:12:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: pgsql: Avoid unsatisfied-external-reference errors in static inlines. Content-Language: en-US To: Tom Lane , pgsql-committers@lists.postgresql.org References: From: Peter Eisentraut In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 13.07.22 19:37, Tom Lane wrote: > Avoid unsatisfied-external-reference errors in static inlines. > > Commit 9c727360b neglected the lesson we've learned before: > protect references to backend global variables with #ifndef FRONTEND. What platforms did this fail on? How can one observe the failure locally?