Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <pgsql-committers-owner+archive@lists.postgresql.org>)
	id 1gnzfG-0006Ic-II
	for pgsql-committers@arkaria.postgresql.org; Mon, 28 Jan 2019 05:40:58 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-committers-owner+archive@lists.postgresql.org>)
	id 1gnzfF-0007ux-EK
	for pgsql-committers@arkaria.postgresql.org; Mon, 28 Jan 2019 05:40:57 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <andrew@tao11.riddles.org.uk>)
	id 1gnzfF-0007un-5w; Mon, 28 Jan 2019 05:40:57 +0000
Received: from lungold.riddles.org.uk ([82.68.208.19])
	by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <andrew@tao11.riddles.org.uk>)
	id 1gnzf8-0001vH-OY; Mon, 28 Jan 2019 05:40:56 +0000
Received: from [192.168.127.1] (port=42694 helo=caithnard.riddles.org.uk)
	by lungold.riddles.org.uk with esmtps
 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256)
	(Exim 4.88 (FreeBSD))
	(envelope-from <andrew@tao11.riddles.org.uk>)
	id 1gnzf6-0001We-0C; Mon, 28 Jan 2019 05:40:48 +0000
Received: from [127.0.0.1] (port=18018 helo=caithnard.riddles.org.uk)
	by caithnard.riddles.org.uk with esmtp (Exim 4.89 (FreeBSD))
	(envelope-from <andrew@tao11.riddles.org.uk>)
	id 1gnzf5-000Cwx-BR; Mon, 28 Jan 2019 05:40:47 +0000
From: Andrew Gierth <andrew@tao11.riddles.org.uk>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Amit Kapila <akapila@postgresql.org>,
  PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
  John Naylor <john.naylor@2ndquadrant.com>,
  pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Avoid creation of the free space map for small heap
 relations.
In-Reply-To: 
 <CAA4eK1LjXLFZ0Q1mXO5h8b6Smw=hsDvT3ZLcw5wcXbC7TSuwEA@mail.gmail.com>
	(Amit Kapila's message of "Mon, 28 Jan 2019 11:07:11 +0530")
Message-ID: <8736pdjq73.fsf@news-spur.riddles.org.uk>
References: <E1gnwx4-0003C9-BR@gemulon.postgresql.org>
	<CAA4eK1KvRqjYYaYWpkb=g76uM=MkfN4xE4fN0S6dgwO0sj_jxA@mail.gmail.com>
	<CAA4eK1JntHd7X6dLJVPGYV917HejjhbMKXn9m_RnnCE162LbLA@mail.gmail.com>
	<877eepjt3p.fsf@news-spur.riddles.org.uk>
	<CAA4eK1LjXLFZ0Q1mXO5h8b6Smw=hsDvT3ZLcw5wcXbC7TSuwEA@mail.gmail.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (berkeley-unix)
Date: Mon, 28 Jan 2019 05:40:47 +0000
MIME-Version: 1.0
Content-Type: text/plain
List-Id: <pgsql-committers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-committers@lists.postgresql.org>
List-Owner: <mailto:pgsql-committers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-committers>
Precedence: bulk

>>>>> "Amit" == Amit Kapila <amit.kapila16@gmail.com> writes:

 Amit> Yes, so this could be the cause of the problem. I think we need
 Amit> to change the tests added by the patch such that they don't rely
 Amit> on vacuum to remove dead-row versions? Do you or anybody else see
 Amit> any better way to fix this?

Do you just need to create free space on a page that didn't have enough
before? It might be worth tweaking the fillfactor rather than trying to
delete anything.

-- 
Andrew (irc:RhodiumToad)