Feedback-ID: id4a34324:Fastmail
Date: Tue, 08 Apr 2025 10:24:21 -0400
From: Andres Freund <andres@anarazel.de>
To: pgsql-committers@lists.postgresql.org, Tom Lane <tgl@sss.pgh.pa.us>,
 Daniel Gustafsson <daniel@yesql.se>
CC: Tomas Vondra <tomas.vondra@postgresql.org>
Subject: Re: pgsql: Add support for basic NUMA awareness
User-Agent: K-9 Mail for Android
In-Reply-To: <3976705.1744121148@sss.pgh.pa.us>
References: <E1u1tr8-003BbL-20@gemulon.postgresql.org>
 <7ABC1680-3B82-4DD4-B9B7-BB4F74668B1A@yesql.se>
 <3976705.1744121148@sss.pgh.pa.us>
Message-ID: <87592CF0-5F4E-4043-BC57-E635E0924995@anarazel.de>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/87592CF0-5F4E-4043-BC57-E635E0924995%40anarazel.de>
Precedence: bulk

Hi,

On April 8, 2025 10:05:48 AM EDT, Tom Lane <tgl@sss=2Epgh=2Epa=2Eus> wrote=
:
>Daniel Gustafsson <daniel@yesql=2Ese> writes:
>>> On 7 Apr 2025, at 23:18, Tomas Vondra <tomas=2Evondra@postgresql=2Eorg=
> wrote:
>>> Add support for basic NUMA awareness
>
>> dogfish is a little bit upset it seems=2E
>
>Hm, but why isn't anything else?

I assume it's a question of degree of parallelism=2E I was able to repro t=
he failure when building from a clean tree with unlimited parallelism=2E


>I noticed this a little further up in dogfish's log:
>
>ninja: bad depfile: expected ':', saw 's'

I noticed that too - but it happened even before the hard failures=2E Will=
 look at it in a bit=2E


>> Looking at pg_numa=2Ec, shouldn't the include of postgres=2Eh have an #=
ifndef
>> FRONTEND guard for postgres_fe=2Eh as well?
>
>No, because it's evidently backend-only code=2E  The real question
>is why is it in src/port/, because everything there gets built
>for both frontend and backend=2E

I think part of the file would make sense to eventually use in FE code, we=
 should move the SQL function and the page size function out=2E=20

Greetings,=20

Andres
--=20
Sent from my Android device with K-9 Mail=2E Please excuse my brevity=2E