Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mZwke-000561-2c for pgsql-hackers@arkaria.postgresql.org; Mon, 11 Oct 2021 14:58:04 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1mZwkd-000623-1Z for pgsql-hackers@arkaria.postgresql.org; Mon, 11 Oct 2021 14:58:03 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mZwkc-0005yp-Q0 for pgsql-hackers@lists.postgresql.org; Mon, 11 Oct 2021 14:58:02 +0000 Received: from relay8-d.mail.gandi.net ([217.70.183.201]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mZwka-0002bK-ES for pgsql-hackers@lists.postgresql.org; Mon, 11 Oct 2021 14:58:01 +0000 Received: (Authenticated sender: adsend@dunslane.net) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id C67421BF20E; Mon, 11 Oct 2021 14:57:55 +0000 (UTC) Subject: Re: pgsql: Adjust configure to insist on Perl version >= 5.8.3. To: Noah Misch , Tom Lane Cc: Daniel Gustafsson , Postgres hackers , Craig Ringer References: <173186.1633635888@sss.pgh.pa.us> <20211008025659.GA398563@rfd.leadboat.com> <197091.1633664351@sss.pgh.pa.us> <20211008042454.GB398563@rfd.leadboat.com> <03177128-BE87-4520-90D1-D5FA16B79EB6@yesql.se> <234637.1633709021@sss.pgh.pa.us> <20211009192333.GA450252@rfd.leadboat.com> <245162.1633808657@sss.pgh.pa.us> <20211009195947.GB450252@rfd.leadboat.com> <247872.1633811686@sss.pgh.pa.us> <20211010022553.GB458218@rfd.leadboat.com> From: Andrew Dunstan Message-ID: <876cb394-404f-d4d0-9a0a-847ce6a5c459@dunslane.net> Date: Mon, 11 Oct 2021 10:57:53 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <20211010022553.GB458218@rfd.leadboat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 10/9/21 10:25 PM, Noah Misch wrote: > On Sat, Oct 09, 2021 at 04:34:46PM -0400, Tom Lane wrote: >> Hah ... your backpan link led me to realize the actual problem with >> Test::More. It got folded into Test::Simple at some point, and >> evidently cpanm isn't smart enough to handle a request for a back >> version in such cases. But this works: >> >> $ cpanm install Test::Simple@0.87_01 >> ... >> $ perl -MTest::More -e 'print $Test::More::VERSION, "\n";' >> 0.8701 >> >> So we oughta recommend that instead. Now I'm wondering what >> version of IPC::Run to recommend. > You mentioned prairiedog uses IPC::Run 0.79. That's from 2005. (Perl 5.8.3 > is from 2004, and Test::More 0.87 is from 2009.) I'd just use 0.79 in the > README recipe. IPC::Run is easy to upgrade, so if we find cause to rely on a > newer version, I'd be fine updating that requirement. > > Why don't we specify the minimum versions required of these somewhere in the perl code? Perl is pretty good at this. e.g. use IPC::Run 0.79; use Test::More 0.87; It will choke if the supplied version is older. We could even put lines like this in a small script that configure could run. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com