public inbox for [email protected]  

help / color / mirror / Atom feed

From: Peter Eisentraut <[email protected]>
To: Amul Sul <[email protected]>
Cc: Andrew Dunstan <[email protected]>
Cc: [email protected]
Subject: Re: pgsql: pg_verifybackup: Enable WAL parsing for tar-format backups
Date: Wed, 6 May 2026 10:53:31 +0200
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAAJ_b95pj6rq4yw09Ds-7x8-HLHFbseJEXag5TDPb_CZewBgRA@mail.gmail.com>
References: <[email protected]>
	<[email protected]>
	<CAAJ_b95pj6rq4yw09Ds-7x8-HLHFbseJEXag5TDPb_CZewBgRA@mail.gmail.com>

On 04.05.26 13:16, Amul Sul wrote:
> On Mon, May 4, 2026 at 3:00 PM Peter Eisentraut <[email protected]> wrote:
>>
>> On 20.03.26 20:32, Andrew Dunstan wrote:
>>> pg_verifybackup: Enable WAL parsing for tar-format backups
>>>
>>> Now that pg_waldump supports reading WAL from tar archives, remove the
>>> restriction that forced --no-parse-wal for tar-format backups.
>>>
>>> pg_verifybackup now automatically locates the WAL archive: it looks for
>>> a separate pg_wal.tar first, then falls back to the main base.tar.  A
>>> new --wal-path option (replacing the old --wal-directory, which is kept
>>> as a silent alias) accepts either a directory or a tar archive path.
>>
>> In the past, we have opted against silent aliases when changing a
>> command-line option.  All options should be documented, even if they are
>> deprecated.  Otherwise, it's confusing for users moving between major
>> versions or those who find that undocumented options happen to work.
>> See commit 35ce24c333c for an example how this was done in the past.
>>
>> I suggest the option --wal-directory should be added back to the
>> documentation and help output.
> 
> Agreed. Attached is a quick fix.

Committed, thanks.

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: pgsql: pg_verifybackup: Enable WAL parsing for tar-format backups
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox