From: ilmari@ilmari.org (Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?=)
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Geoghegan <pg@bowt.ie>,  Robert Haas <robertmhaas@gmail.com>,
  Christoph Berg <myon@debian.org>,
  PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: pgsql: Add basic TAP tests for psql's tab-completion logic.
References: <20200103170226.GB32629@msg.df7cb.de>
	<CAH2-WznPzfWHu8PQwv1Qjpf4wQVPaaWpoO5NunFz9zsYKB4uJA@mail.gmail.com>
	<22669.1578104202@sss.pgh.pa.us>
	<CAH2-WznyU3QxzRr12W_tJAzjwM9qd6bh_ZGx3Xupk3RqE1t72A@mail.gmail.com>
	<25298.1578106280@sss.pgh.pa.us>
	<CAH2-Wzkq4OELzn3yZvuqsPuso5JfSXdaD+yW=1VMz2YpXTBYxA@mail.gmail.com>
	<CAH2-Wzk3xfc53A0KZRe4Xu9TALRU=HSfSVZqx3jBuws08mG-ew@mail.gmail.com>
	<3055.1578115809@sss.pgh.pa.us>
	<CAH2-Wz=CtOruqXPd3naWXNiQ0WvLSFnCDYmSDWy0hKiLrppXDQ@mail.gmail.com>
	<8038.1578119995@sss.pgh.pa.us>
	<CAH2-Wz=f4B9+Ob-51-5z9G8a9LmztNpgo0YbKuTjxus3kFjpCg@mail.gmail.com>
	<9256.1578121229@sss.pgh.pa.us> <25739.1578161968@sss.pgh.pa.us>
	<22817.1578167447@sss.pgh.pa.us>
	<CAH2-Wz=4U_qKeLjN2FnLmSON8B5DgpMNXRdR4mLzgZjdpaMfUg@mail.gmail.com>
	<26857.1578183240@sss.pgh.pa.us>
	<CAH2-Wz=mJPd5cZwUdHGQ5sQsz6X58DivewER_WQ2+bx_ZU6yGw@mail.gmail.com>
	<912.1578189448@sss.pgh.pa.us>
	<CAH2-WzkicOOPb2AHa+PSeQ1-N3qUV-0TKMX=EHVi55eH5Rtj9A@mail.gmail.com>
	<1888.1578190678@sss.pgh.pa.us> <87k16610xk.fsf@wibble.ilmari.org>
Date: Sun, 05 Jan 2020 13:39:11 +0000
In-Reply-To: <87k16610xk.fsf@wibble.ilmari.org> ("Dagfinn Ilmari
 \=\?utf-8\?Q\?Manns\=C3\=A5ker\=22's\?\=
	message of "Sun, 05 Jan 2020 13:35:03 +0000")
Message-ID: <87h81a10qo.fsf@wibble.ilmari.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Precedence: bulk

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit

ilmari@ilmari.org (Dagfinn Ilmari Mannsåker) writes:

> Tom Lane <tgl@sss.pgh.pa.us> writes:
>
>> Cool, I'll go commit a fix along those lines.  Thanks for tracing
>> this down!
>
> Here's one final style cleanup for the TAP test.
>
> - use like() for the banner test
> - pass the regexes around as qr// objects, so they can be
>   syntax-highlighted properly, and don't need regex
>   metacharacter-escaping backslashes doubled.
> - include the regex that didn't match in the diagnostic

This time with the actual attachment...

- ilmari
-- 
- Twitter seems more influential [than blogs] in the 'gets reported in
  the mainstream press' sense at least.               - Matt McLeod
- That'd be because the content of a tweet is easier to condense down
  to a mainstream media article.                      - Calle Dybedahl

--=-=-=
Content-Type: text/x-diff
Content-Disposition: inline;
 filename=0001-Use-qr-for-passed-in-regexes-in-tab-completion-TAP-t.patch