Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1io63v-0006em-6Q for pgsql-hackers@arkaria.postgresql.org; Sun, 05 Jan 2020 13:35:24 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1io63t-0002gr-86 for pgsql-hackers@arkaria.postgresql.org; Sun, 05 Jan 2020 13:35:21 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1io63r-0002gj-9L for pgsql-hackers@lists.postgresql.org; Sun, 05 Jan 2020 13:35:20 +0000 Received: from wnew3-smtp.messagingengine.com ([64.147.123.17]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1io63j-0003Sp-1O for pgsql-hackers@postgresql.org; Sun, 05 Jan 2020 13:35:18 +0000 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailnew.west.internal (Postfix) with ESMTP id 5373A5C6; Sun, 5 Jan 2020 08:35:07 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sun, 05 Jan 2020 08:35:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ilmari.org; h= from:to:cc:subject:references:date:in-reply-to:message-id :mime-version:content-type; s=fm1; bh=7dnBfQ0mSO7ufYkJuCZAeKebqm elEZY1CENX65SGJTA=; b=t8gT21Y/DFGCzEQ5jfW//j7vnIhtxK0cExcSpnyZil uvlznbDs2urV5Q9HiK6x7qSO90mZ2WXAxUU9cRHbDskRD1WoMejifuYc8G68BLu8 hFA6J/wczJtz+wYrxpg422YVq8yK2NE204A/s88O3ykQp+LOzdkzYED1NSxHpG86 7FhbpH3PAnPFFBQXYSnrB+DzC913S9UcgxUUCoLhN3Q3bmgqkxGFRcRp7GZvzV9w Q+Cpd928Xz7Mw63p6us2lcc6UHMNkls6YcRGDOVlIX4m5dVtDDpDt9ex8E1kDgUX 9fGDqiYeaWJJLHQJPvdjdtZf4OS8Qz9CSNhBU5MBsA0A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=7dnBfQ 0mSO7ufYkJuCZAeKebqmelEZY1CENX65SGJTA=; b=KxSgqIHtFA+EGFtz3TDEky YUNjP27Ld3TQXL6bZHEIUSTCEnjIpv2SxDqBlWKNZZgtis9Sn5MGWnflFX7S8Ju7 auNKZZzW1VhoCtoUNRQlIm4TGNwI1+2XzGKvantt0kSYeAjsLe6F9fh4p9ryJQwT 6ASl524QdNSgpA9PazwkffTw6SapDd19xfKLk1FLxelH8xrs7pV9P8b2s/p0jcur lC+qM7jA6Oekxen8o+oKWKBgLdnfM/VSm+jpA7Ro/ta7xcIxI992KxYHBZuIzGWv RnFhm+ebwVbgNUkgNOqBB4g9kRuVGnBWHIs50CgGjbtjFVOfVVORavSjHalHh9Hg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrvdegkedgheefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufhfffgjkfgfgggtsehttdertddtreejnecuhfhrohhmpehilhhmrghr ihesihhlmhgrrhhirdhorhhgucdlffgrghhfihhnnhcukfhlmhgrrhhiucforghnnhhsno hkvghrmdenucfkphepgeeirdegfedrudehrddvhedvnecurfgrrhgrmhepmhgrihhlfhhr ohhmpehilhhmrghrihesihhlmhgrrhhirdhorhhgnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from wibble.ilmari.org (wibble.ilmari.org [46.43.15.252]) by mail.messagingengine.com (Postfix) with ESMTPA id 0015F8005C; Sun, 5 Jan 2020 08:35:04 -0500 (EST) From: ilmari@ilmari.org (Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?=) To: Tom Lane Cc: Peter Geoghegan , Robert Haas , Christoph Berg , PostgreSQL Hackers Subject: Re: pgsql: Add basic TAP tests for psql's tab-completion logic. References: <20200103170226.GB32629@msg.df7cb.de> <22669.1578104202@sss.pgh.pa.us> <25298.1578106280@sss.pgh.pa.us> <3055.1578115809@sss.pgh.pa.us> <8038.1578119995@sss.pgh.pa.us> <9256.1578121229@sss.pgh.pa.us> <25739.1578161968@sss.pgh.pa.us> <22817.1578167447@sss.pgh.pa.us> <26857.1578183240@sss.pgh.pa.us> <912.1578189448@sss.pgh.pa.us> <1888.1578190678@sss.pgh.pa.us> Date: Sun, 05 Jan 2020 13:35:03 +0000 In-Reply-To: <1888.1578190678@sss.pgh.pa.us> (Tom Lane's message of "Sat, 04 Jan 2020 21:17:58 -0500") Message-ID: <87k16610xk.fsf@wibble.ilmari.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Tom Lane writes: > Cool, I'll go commit a fix along those lines. Thanks for tracing > this down! Here's one final style cleanup for the TAP test. - use like() for the banner test - pass the regexes around as qr// objects, so they can be syntax-highlighted properly, and don't need regex metacharacter-escaping backslashes doubled. - include the regex that didn't match in the diagnostic - ilmari -- "The surreality of the universe tends towards a maximum" -- Skud's Law "Never formulate a law or axiom that you're not prepared to live with the consequences of." -- Skud's Meta-Law