Received: from malur.postgresql.org ([2a02:16a8:dc51::56])
	by arkaria.postgresql.org with esmtps
 (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1fbLam-0004a6-Rk
	for pgsql-hackers@arkaria.postgresql.org; Fri, 06 Jul 2018 07:55:49 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1fbLal-0005a2-1s
	for pgsql-hackers@arkaria.postgresql.org; Fri, 06 Jul 2018 07:55:47 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <a.sher@postgrespro.ru>)
	id 1fbLak-0005Zv-LX
	for pgsql-hackers@lists.postgresql.org; Fri, 06 Jul 2018 07:55:46 +0000
Received: from mail.postgrespro.ru ([93.174.131.138])
	by magus.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <a.sher@postgrespro.ru>)
	id 1fbLah-0001dj-Lo
	for pgsql-hackers@lists.postgresql.org; Fri, 06 Jul 2018 07:55:46 +0000
Received: from localhost (localhost [127.0.0.1])
	by mail.postgrespro.ru (Postfix) with ESMTP id 049A821C2AF2;
	Fri,  6 Jul 2018 10:55:42 +0300 (MSK)
X-Virus-Scanned: Debian amavisd-new at postgrespro.ru
X-Spam-Flag: NO
X-Spam-Score: 0
X-Spam-Level: 
X-Spam-Status: No, score=x tagged_above=-99 required=4 WHITELISTED tests=[]
	autolearn=unavailable
Received: from ars-thinkpad (nat03-43-2.netorn.net [188.35.130.88])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client did not present a certificate)
	by mail.postgrespro.ru (Postfix) with ESMTPSA id AB36221C2AEB;
	Fri,  6 Jul 2018 10:55:41 +0300 (MSK)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=postgrespro.ru;
	s=mail; t=1530863741;
	bh=+N5fvtfjWkeiNP+GfV4c+++IYDT5rXvLdr0VWJMSCNM=;
	h=References:From:To:Cc:Subject:In-reply-to:Date;
	b=qlpHbYlC7SkxFUoHdDjKOaFhujyDdtLRHH2XxXVTqihn1zujxBjeutJJIJnMbNFgK
	 wqXl32mRn68zeRVz+IpjMjepqtdsFgkk2AZI2kOS066OcctHd4n3MNdzIDmOs5itXx
	 LKrIyU8BZzbmA5D1J3x73ioUOzwrWGuKyfI3MOxE=
References: <87r2kliqja.fsf@ars-thinkpad>
 <20180705204824.3rfp6co4dr5ph4n6@alvherre.pgsql>
User-agent: mu4e 1.1.0; emacs 26.0.50
From: Arseny Sher <a.sher@postgrespro.ru>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers@lists.postgresql.org
Subject: Re: pgsql: Fix "base" snapshot handling in logical decoding
In-reply-to: <20180705204824.3rfp6co4dr5ph4n6@alvherre.pgsql>
Date: Fri, 06 Jul 2018 10:55:41 +0300
Message-ID: <87muv4iyrm.fsf@ars-thinkpad>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk


Alvaro Herrera <alvherre@2ndquadrant.com> writes:

> I just don't see it that VACUUM FULL would change the xmin of anything
> to FrozenXid, and in my experiments it doesn't.  Did you mean VACUUM
> FREEZE?

Well, docs for VACUUM say:

FREEZE

    Selects aggressive “freezing” of tuples. Specifying FREEZE is
    equivalent to performing VACUUM with the vacuum_freeze_min_age and
    vacuum_freeze_table_age parameters set to zero. Aggressive freezing
    is always performed when the table is rewritten, so this option is
    redundant when FULL is specified.

So this is literally the same. rewrite_heap_tuple does the job.


> Thanks for the detective work!  I pushed this test change.

Thank you, I appreciate this.

--
Arseny Sher
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company