From: Tom Lane <tgl@sss.pgh.pa.us>
To: Tomas Vondra <tomas.vondra@postgresql.org>
cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Rework the pg_statistic_ext catalog
In-reply-to: <E1hcHz2-0005mY-5A@gemulon.postgresql.org>
References: <E1hcHz2-0005mY-5A@gemulon.postgresql.org>
Comments: In-reply-to Tomas Vondra <tomas.vondra@postgresql.org>
	message dated "Sat, 15 Jun 2019 23:21:16 -0000"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <8832.1560647898.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Sat, 15 Jun 2019 21:18:18 -0400
Message-ID: <8833.1560647898@sss.pgh.pa.us>
Precedence: bulk

Tomas Vondra <tomas.vondra@postgresql.org> writes:
> Rework the pg_statistic_ext catalog

So ... not one of the buildfarm members that are running TAP tests
likes this.  The failures look like

# Running: pg_dump --no-sync --file=3D/Users/tgl/pgsql/src/bin/pg_dump/tmp=
_check/tmp_test_cSh8/role.sql --role=3Dregress_dump_test_role --schema=3Dd=
ump_test_second_schema postgres
pg_dump: error: query failed: ERROR:  permission denied for table pg_stati=
stic_ext
pg_dump: error: query was: SELECT tableoid, oid, stxname, stxnamespace, (S=
ELECT rolname FROM pg_catalog.pg_roles WHERE oid =3D stxowner) AS rolname =
FROM pg_catalog.pg_statistic_ext
not ok 4576 - role: pg_dump runs

#   Failed test 'role: pg_dump runs'
#   at t/002_pg_dump.pl line 3418.

I think probably what's happening is that pg_dump is still trying to dump
directly from the catalog, when what it needs to do now is dump from the
view, in case it's not running as superuser.

			regards, tom lane