Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gnzn0-0006iE-UX for pgsql-committers@arkaria.postgresql.org; Mon, 28 Jan 2019 05:48:59 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gnzmz-0007ES-Je for pgsql-committers@arkaria.postgresql.org; Mon, 28 Jan 2019 05:48:57 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gnzmz-0007EG-AL; Mon, 28 Jan 2019 05:48:57 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gnzmw-00024B-MO; Mon, 28 Jan 2019 05:48:56 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id x0S5mpN9008873; Mon, 28 Jan 2019 00:48:51 -0500 From: Tom Lane To: Amit Kapila cc: Andrew Gierth , Amit Kapila , PostgreSQL Hackers , John Naylor , pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Avoid creation of the free space map for small heap relations. In-reply-to: References: <877eepjt3p.fsf@news-spur.riddles.org.uk> Comments: In-reply-to Amit Kapila message dated "Mon, 28 Jan 2019 11:07:11 +0530" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <8871.1548654531.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Mon, 28 Jan 2019 00:48:51 -0500 Message-ID: <8872.1548654531@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Amit Kapila writes: > Yes, so this could be the cause of the problem. I think we need to > change the tests added by the patch such that they don't rely on > vacuum to remove dead-row versions? Do you or anybody else see any > better way to fix this? To be blunt, this patch needs to be reverted immediately. The failures that are showing up are not just "the fsm test is not portable" problems. See for example https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=3Dmantid&dt=3D2019= -01-28%2005%3A07%3A06 https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=3Ddromedary&dt=3D2= 019-01-28%2003%3A07%3A39 https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=3Dlapwing&dt=3D201= 9-01-28%2003%3A20%3A02 I don't know what the common thread is here, but you don't get to leave the buildfarm broken this badly while you figure it out. regards, tom lane