Subject: Re: pgsql: doc: Further clarify how recovery target parameters are
 applied
To: Fujii Masao <masao.fujii@gmail.com>,
 Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>,
 pgsql-committers@lists.postgresql.org
References: 
 <CAHGQGwF7tLDk=M5tGZx=ROy_o2-n9fQ5v6-fnzBNF1yWxoEZoA@mail.gmail.com>
 <20191105132123.GA1578@alvherre.pgsql>
 <CAHGQGwG2KenPa8hTtQ1opgpgVtMQcQ2oAx_mTkyV0YjgaN5M1w@mail.gmail.com>
 <e87b6c74-ae0b-bc97-b4fd-3b26f5b25ea4@2ndquadrant.com>
 <CAHGQGwHN_42hsKGwZo8YjXvOR7XuqzoXxMzBacBFUDN-NQ6poA@mail.gmail.com>
From: David Steele <david@pgmasters.net>
Message-ID: <8bd7266c-f720-1eda-c94e-77e815768b7b@pgmasters.net>
Date: Thu, 7 Nov 2019 12:33:33 -0500
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0)
 Gecko/20100101 Thunderbird/60.9.0
MIME-Version: 1.0
In-Reply-To: 
 <CAHGQGwHN_42hsKGwZo8YjXvOR7XuqzoXxMzBacBFUDN-NQ6poA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 11/6/19 4:49 AM, Fujii Masao wrote:
> On Wed, Nov 6, 2019 at 4:29 PM Peter Eisentraut
> <peter.eisentraut@2ndquadrant.com> wrote:
>>
>> On 2019-11-06 05:48, Fujii Masao wrote:
>>> Patch attached. As I argued upthread, IMO it's better to remove
>>> the latter description from the doc and the patch does that.
>>> Also the patch adds "mainly" into the former description.
>>
>> I think we should list explicitly what is applied and what is not.  This
>> is the reference documentation after all.
> 
> Or it might be better to add something like "This setting has no effect if
> in standby mode / archive recovery" into the description of each parameter,
> instead.

+1.  This will probably be easier to maintain and less confusing overall.

-- 
-David
david@pgmasters.net