Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q4JR8-0001O3-Hf for pgsql-hackers@arkaria.postgresql.org; Wed, 31 May 2023 10:52:15 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1q4JR6-0004ZU-4K for pgsql-hackers@arkaria.postgresql.org; Wed, 31 May 2023 10:52:12 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q4JR4-0004ZF-L1 for pgsql-hackers@lists.postgresql.org; Wed, 31 May 2023 10:52:11 +0000 Received: from out2-smtp.messagingengine.com ([66.111.4.26]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1q4JR1-002saV-3O for pgsql-hackers@lists.postgresql.org; Wed, 31 May 2023 10:52:09 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 926B45C007C; Wed, 31 May 2023 06:52:05 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Wed, 31 May 2023 06:52:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eisentraut.org; h=cc:cc:content-transfer-encoding:content-type:content-type :date:date:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to; s=fm3; t=1685530325; x=1685616725; bh=Mpxeb0iA5QZuMMqfJs4L7ydoN wVObzJYcFq18Q0j1z0=; b=PfXQc3HOMLUKw8N6a5EfSS+B+PXqkWEt31gruMFjp fLV5XO3HXArBidpI2JcH6V0Znu8l7hXE9LLpwyVB/YlmOM1ljEdzGQwIMkiuvw8h ox0zYsHTDJARUUWWG1ZSLaxkVavdSSj4Mcvfkpr2p8KP2Vuu2oYNOHNpcpH1FbT4 giISwEaOkWRb272CFqMSXQyu+Eze+PZcnuWVzkQH+sv12NkbcL+hS+kf5nuqXs5v ETiA0iSRmFJJLyVrsT1QgkuBcbC0jt6o3OedxIDO03ExuBW0/Kyb3HblhBklzK+s GGnMRoYfW8RD3dq+3eJraOo+ha/Fl2iITZHSRfLqciafQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1685530325; x=1685616725; bh=Mpxeb0iA5QZuMMqfJs4L7ydoNwVObzJYcFq 18Q0j1z0=; b=HRjGF1pdmhZXzjOQl9TAV4MQNEYJwvCRVqZmmKPZit/OexOgfM+ geMB7xrzoRthiWwhhN5TzlyDYP2KD8atqFG5gkLOklbE6n+AC/hkCt01Ei1hbw2M 24LjbdzYuLjSUoO+I0+dNhg0RE+inlFkOC66be1VQiZ2O3Jo5TI/7exkb49hrZK0 /+BhORK+eL3U/StyXHz5yTv6SLH/rx8XlcUJhLlr6yXKLjGjUZ1Oq0G8pnNsHDHa 3vIURXHsJqh75tX3r8Ka26AaA1sLuuLhYVmz/hSfbN7CpY8pdgzIqhqR5ml4cR07 oSxNxG3Aozfho8j8jTszCouWas5o303C06Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeekledgfedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpefrvght vghrucfgihhsvghnthhrrghuthcuoehpvghtvghrsegvihhsvghnthhrrghuthdrohhrgh eqnecuggftrfgrthhtvghrnhepheeiuefhleelfeeikeehkefgkeeggfevheeuvdejveet tdegleekffffieekuedtnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrg hilhhfrhhomhepphgvthgvrhesvghishgvnhhtrhgruhhtrdhorhhg X-ME-Proxy: Feedback-ID: ie0a040ee:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 31 May 2023 06:52:04 -0400 (EDT) Message-ID: <8c1ff0a4-0295-cb60-191e-7ea584eb405b@eisentraut.org> Date: Wed, 31 May 2023 06:52:03 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: testing dist tarballs Content-Language: en-US To: Andres Freund Cc: Tom Lane , Christoph Berg , PostgreSQL Hackers References: <933499.1684853190@sss.pgh.pa.us> <20230523184157.ao4ytkwqxkgp3glk@awork3.anarazel.de> <974623.1684867863@sss.pgh.pa.us> <20230524212437.jm6e3iiehtehivbh@awork3.anarazel.de> <20230527184713.32pjrsfgm2pixwmu@alap3.anarazel.de> From: Peter Eisentraut In-Reply-To: <20230527184713.32pjrsfgm2pixwmu@alap3.anarazel.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 27.05.23 14:47, Andres Freund wrote: >>> Separately, it's somewhat confusing that we include errcodes.h etc in >>> src/backend/utils, rather than its final location, in src/include/utils. It >>> works, even without perl, because copying the file doesn't require perl, it's >>> just generating it... >> >> The "copying" is actually a symlink, right? I don't think we want to ship >> symlinks in the tarball? > > Fair point - still seems we should just create the files in the right > directory instead of doing it in the wrong place and then creating symlinks to > make them accessible... Right. I think the reason this was set up this way is that with make it is generally dubious to create target files outside of the current directory.