Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nVsPi-0004z1-R0 for pgsql-hackers@arkaria.postgresql.org; Sun, 20 Mar 2022 10:03:55 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nVsPg-0000Ow-J4 for pgsql-hackers@arkaria.postgresql.org; Sun, 20 Mar 2022 10:03:52 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nVsPf-0000Om-DV for pgsql-hackers@lists.postgresql.org; Sun, 20 Mar 2022 10:03:52 +0000 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nVsPb-0002Nu-3q for pgsql-hackers@lists.postgresql.org; Sun, 20 Mar 2022 10:03:50 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id F39A93201DA2; Sun, 20 Mar 2022 06:03:42 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Sun, 20 Mar 2022 06:03:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=+rKC+f3DLRh/rlNHPXJEuN0JOW315NPiLDjd4mFZ6 kM=; b=Uc5hQ7jpv19OENm2GmCC1YAXwGiXc4jiLsxs+tZk8rY7/SVIqPR4krJsl RSt07K0ZY46gCz0nNG7g5bLc9H15sMuvIvjf1ul2XmDszcL3iRyeiHSXdrATYhuU UtV/j30t9kg7IqnOIAVfMIESy7VnA4p6yLkwcZZPtBiGbvSDmzSaId0SpcJJDaj4 RWbKbuFW/IKxTO9ccfhpRHwj8bMZdi7s1Zkt++vL3Sw9w97VDMItj0AXr4xFih/y I0SXI973MgK/Iz/4ePMjiLuKfqnUVwTTkh2Xc9GZIXtybTorJIZyVAHd9ltwJvl2 rflYbGY74r/ZJOqJ8tvmbiklrhxvg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudeguddgudduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvfhfhjggtgfesthejredttdefjeenucfhrhhomheprfgvthgv rhcugfhishgvnhhtrhgruhhtuceophgvthgvrhdrvghishgvnhhtrhgruhhtsegvnhhtvg hrphhrihhsvggusgdrtghomheqnecuggftrfgrthhtvghrnhepfeejgeehteeuhfevvedu leeufedtjeetiefftedvudfhtdeifefgueettdevgefgnecuvehluhhsthgvrhfuihiivg eptdenucfrrghrrghmpehmrghilhhfrhhomhepphgvthgvrhdrvghishgvnhhtrhgruhht segvnhhtvghrphhrihhsvggusgdrtghomh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 20 Mar 2022 06:03:40 -0400 (EDT) Message-ID: <8c3771a7-5c73-5ccf-408a-5d6c6c96ebc0@enterprisedb.com> Date: Sun, 20 Mar 2022 11:03:38 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: pgsql: Add option to use ICU as global locale provider Content-Language: en-US To: Julien Rouhaud , Andres Freund Cc: Thomas Munro , Michael Paquier , pgsql-hackers@lists.postgresql.org References: <20220318031244.tu3wwlyxxabzq3iu@jrouhaud> <20220318063648.4ja6rxlyzvc3viio@jrouhaud> <20220318074051.n46mkwp2zkbxeesf@jrouhaud> <20220318092749.363m4uv6rq24lctz@jrouhaud> <7960418a-b5ac-8a53-bf45-dec2b48e01e9@enterprisedb.com> <20220318220959.pc4hpdmat6gbcdc2@alap3.anarazel.de> <20220319041459.qqqiqh335sga5ezj@jrouhaud> From: Peter Eisentraut In-Reply-To: <20220319041459.qqqiqh335sga5ezj@jrouhaud> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 19.03.22 05:14, Julien Rouhaud wrote: > On Fri, Mar 18, 2022 at 03:09:59PM -0700, Andres Freund wrote: >> Hi, >> >> On 2022-03-18 20:28:58 +0100, Peter Eisentraut wrote: >>> Why does your patch introduce a function check_icu_locale() that is only >>> called once? Did you have further plans for that? >> >> I like that it moves ICU code out of dbcommands.c > > Yes, it seemed cleaner this way. But more importantly code outside pg_locale.c > really shouldn't have to deal with ICU specific version code. > > I'm attaching a v2, addressing Peter and Tom comments to not duplicate the old > ICU versions attribute function. I removed the ICU locale check entirely (for > consistency across ICU version) thus removing any need for ucol.h include in > initdb. committed