Feedback-ID: ie0a040ee:Fastmail
Message-ID: <8dbff88c-d1cc-4c4d-a016-1c538c7cf9bd@eisentraut.org>
Date: Tue, 27 Aug 2024 14:41:39 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: pgsql: Restrict accesses to non-system views and foreign tables
 during
To: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: pgsql-committers@lists.postgresql.org
References: <E1saxQr-002nFK-SJ@gemulon.postgresql.org>
 <6a96f1af-22b4-4a80-8161-1f26606b9ee2@eisentraut.org>
 <CAD21AoCB1He62bgtUkgu8mkUtAJpHxC98SM6=oDqbRmLmdhE1g@mail.gmail.com>
Content-Language: en-US
From: Peter Eisentraut <peter@eisentraut.org>
In-Reply-To: 
 <CAD21AoCB1He62bgtUkgu8mkUtAJpHxC98SM6=oDqbRmLmdhE1g@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/8dbff88c-d1cc-4c4d-a016-1c538c7cf9bd%40eisentraut.org>
Precedence: bulk

On 26.08.24 21:05, Masahiko Sawada wrote:
> Maybe using the word "prohibit" makes it a bit clear? For example,

I think that would be much clearer, yes.

> In guc_tables.c:
> Prohibits access to non-system relations of specified kinds

End with period.

> In doc:
> Set relation kinds of non-system relations to which access is
> prohibited.

Still a bit awkward.  Maybe "Set relation kinds for which access to 
non-system relations is prohibited."

> It takes a comma-separated list of relation kinds.
> Currently, the supported relation kinds are view and foreign-table.

Maybe in the documentation it would also be appropriate to mention that 
this is meant to be used by pg_dump, not for general use -- unless it is?