Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.92) (envelope-from ) id 1jA0xD-0006LY-3b for pgsql-committers@arkaria.postgresql.org; Fri, 06 Mar 2020 00:35:03 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1jA0xB-0008QY-S5 for pgsql-committers@arkaria.postgresql.org; Fri, 06 Mar 2020 00:35:01 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1jA0xB-0008QP-HS for pgsql-committers@lists.postgresql.org; Fri, 06 Mar 2020 00:35:01 +0000 Received: from mail.thelabyrinth.net ([45.56.70.56]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jA0x8-0004Ox-F5 for pgsql-committers@lists.postgresql.org; Fri, 06 Mar 2020 00:35:00 +0000 Received: from Davids-MacBook-Pro.local (c-73-39-102-148.hsd1.md.comcast.net [73.39.102.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: dsteele) by mail.thelabyrinth.net (Postfix) with ESMTPSA id ED1AE5465C; Fri, 6 Mar 2020 00:34:56 +0000 (UTC) Subject: Re: pgsql: Avoid -Wconversion warnings when using checksum_impl.h To: Michael Paquier Cc: pgsql-committers@lists.postgresql.org References: <1cf30561-7dad-dc6e-9fc3-5c456948cfeb@pgmasters.net> <20200305233014.GA2501@paquier.xyz> From: David Steele Message-ID: <8ea10012-50bc-5770-8882-622721e45194@pgmasters.net> Date: Thu, 5 Mar 2020 19:34:56 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200305233014.GA2501@paquier.xyz> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 3/5/20 6:30 PM, Michael Paquier wrote: > On Thu, Mar 05, 2020 at 12:51:50PM -0500, David Steele wrote: > >> Bit of a bummer that this passed make check-world, but the pgBackRest tests >> definitely did not like it. > > Is that because you have a copy of this routine in your code? Yes, we pull this file into pgBackRest for our checksum validation. We also do unit and integration tests against it. Regards, -- -David david@pgmasters.net