Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o1AG1-0005Xh-Em for pgsql-committers@arkaria.postgresql.org; Tue, 14 Jun 2022 17:23:13 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1o1AG0-0003pu-AF for pgsql-committers@arkaria.postgresql.org; Tue, 14 Jun 2022 17:23:12 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o1AG0-0003pe-2Z for pgsql-committers@lists.postgresql.org; Tue, 14 Jun 2022 17:23:12 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o1AFt-0002Ua-Nj for pgsql-committers@lists.postgresql.org; Tue, 14 Jun 2022 17:23:11 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 25EHN4gU090596; Tue, 14 Jun 2022 13:23:04 -0400 From: Tom Lane To: Michael Paquier cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Force run of pg_upgrade in the build directory in its TAP test In-reply-to: References: Comments: In-reply-to Michael Paquier message dated "Sat, 04 Jun 2022 03:19:53 -0000" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <90594.1655227384.1@sss.pgh.pa.us> Date: Tue, 14 Jun 2022 13:23:04 -0400 Message-ID: <90595.1655227384@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Michael Paquier writes: > Force run of pg_upgrade in the build directory in its TAP test This commit removed delete_old_cluster.sh etc. from .gitignore, but they are still generated in the current directory, so after running a test in a non-VPATH setup I see $ git status ... Untracked files: (use "git add ..." to include in what will be committed) delete_old_cluster.sh I suppose it would be too user-unfriendly to generate those scripts underneath $PGDATA, so don't we need to put back the .gitignore entries? regards, tom lane