From: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Subject: Re: [COMMITTERS] pgsql: Record full paths of programs sought by
 "configure".
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-committers@postgresql.org,
 PostgreSQL-development <pgsql-hackers@postgresql.org>
References: <E1dcE5n-0005Sk-UE@gemulon.postgresql.org>
 <d6ca14d4-a475-6496-48b6-d9f58b29a875@2ndQuadrant.com>
 <7295.1502133694@sss.pgh.pa.us>
Message-ID: <90c39664-ec60-77dc-9f1b-21e8fa7b864c@2ndQuadrant.com>
Date: Mon, 7 Aug 2017 15:31:50 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.0
MIME-Version: 1.0
In-Reply-To: <7295.1502133694@sss.pgh.pa.us>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Content-Language: en-MW
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org


On 08/07/2017 03:21 PM, Tom Lane wrote:
> Andrew Dunstan <andrew.dunstan@2ndquadrant.com> writes:
>> On 07/31/2017 01:02 PM, Tom Lane wrote:
>>> Record full paths of programs sought by "configure".
>> The problem with this commit, as jacana is demonstrating, is that on
>> Msys it finds the wrong prove. configure needs to run against the perl
>> we build against, i.e. a native Windows perl, but prove needs to run
>> with the perl from the MSys DTK that understands MSys virtualized
>> paths. I have a hack that will allow the buildfarm to overcome the
>> difficulty, (essentially it passes 'PROVE=prove' to make) but that's
>> fairly ugly and certainly non-intuitive for someone running an MSys
>> build and TAP tests without the buildfarm client.
> I'm confused.  AFAIK, that commit did not change which "prove" would
> be used --- at least not unless you change PATH between configure and
> make.  It only changed how specifically that program would be named in
> Makefile.global.  Please clarify how that broke anything.
>
> 	


That's exactly what we do. See
<https://github.com/PGBuildFarm/client-code/blob/master/run_build.pl> at
line 1649.

cheers

andrew


-- 
Andrew Dunstan                https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers