Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1h5FLQ-0005b1-6O
	for pgsql-hackers@arkaria.postgresql.org; Sat, 16 Mar 2019 19:51:48 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1h5FLO-00037t-VG
	for pgsql-hackers@arkaria.postgresql.org; Sat, 16 Mar 2019 19:51:46 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1h5FLO-00037m-Ke
	for pgsql-hackers@lists.postgresql.org; Sat, 16 Mar 2019 19:51:46 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1h5FLH-0004yG-7p
	for pgsql-hackers@lists.postgresql.org; Sat, 16 Mar 2019 19:51:45 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id x2GJpb7f009125;
	Sat, 16 Mar 2019 15:51:37 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
cc: Dean Rasheed <dean.a.rasheed@gmail.com>,
        Michael Paquier <michael@paquier.xyz>,
        PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
        laetitia.avrot@gmail.com
Subject: Re: pgsql: Add support for hyperbolic functions, as well as log10().
In-reply-to: <37d05e7a-19f5-ef19-ab76-8dc81e95b511@2ndQuadrant.com>
References: <E1h3nUY-0000sM-Vf@gemulon.postgresql.org>
 <20190313022159.GR13812@paquier.xyz> <24813.1552447002@sss.pgh.pa.us>
 <20190313050331.GT13812@paquier.xyz> <17820.1552514192@sss.pgh.pa.us>
 <CAEZATCX-mFwmx0NKbGsYJ6RAo8Hb=c+_CeNNXWQ7-BmK2_XVWw@mail.gmail.com>
 <6989.1552538487@sss.pgh.pa.us>
 <9aae40da-9572-a82b-a283-d2158ed6ab0c@2ndQuadrant.com>
 <8795.1552590496@sss.pgh.pa.us>
 <37d05e7a-19f5-ef19-ab76-8dc81e95b511@2ndQuadrant.com>
Comments: In-reply-to Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
	message dated "Thu, 14 Mar 2019 17:09:30 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <9123.1552765897.1@sss.pgh.pa.us>
Date: Sat, 16 Mar 2019 15:51:37 -0400
Message-ID: <9124.1552765897@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

Andrew Dunstan <andrew.dunstan@2ndquadrant.com> writes:
> On 3/14/19 3:08 PM, Tom Lane wrote:
>> I feel therefore that what we should do (barring new evidence) is either
>> 1. Remove all the inf/nan test cases for the hyoerbolic functions ...
>> 2. Just comment out the one failing test, with a note about why.

> 2. would help us memorialize the problem.

Hearing no other comments, done that way.

			regards, tom lane