Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oZmDe-0004MA-0d for pgsql-committers@arkaria.postgresql.org; Sun, 18 Sep 2022 04:47:50 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oZmDa-0001CX-Vz for pgsql-committers@arkaria.postgresql.org; Sun, 18 Sep 2022 04:47:46 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oZmDa-0001BT-Fx for pgsql-committers@lists.postgresql.org; Sun, 18 Sep 2022 04:47:46 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oZmDW-0005zS-MM for pgsql-committers@lists.postgresql.org; Sun, 18 Sep 2022 04:47:44 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 28I4ldmB092292; Sun, 18 Sep 2022 00:47:40 -0400 From: Tom Lane To: Peter Geoghegan cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Harmonize reorderbuffer parameter names. In-reply-to: References: Comments: In-reply-to Peter Geoghegan message dated "Sun, 18 Sep 2022 00:21:23 -0000" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <92290.1663476459.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Sun, 18 Sep 2022 00:47:39 -0400 Message-ID: <92291.1663476459@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Peter Geoghegan writes: > Harmonize reorderbuffer parameter names. I'm confused about this, because it didn't fix the (ahem) poster-child case? -extern void ReorderBufferAssignChild(ReorderBuffer *, TransactionId, Tran= sactionId, XLogRecPtr commit_lsn); -extern void ReorderBufferCommitChild(ReorderBuffer *, TransactionId, Tran= sactionId, +extern void ReorderBufferAssignChild(ReorderBuffer *rb, TransactionId xid= , + TransactionId subxid, XLogRecPtr lsn)= ; +extern void ReorderBufferCommitChild(ReorderBuffer *rb, TransactionId, Tr= ansactionId, XLogRecPtr commit_lsn, XLogRecPtr end= _lsn); ReorderBufferAssignChild is better, but ReorderBufferCommitChild is still short some parameter names. regards, tom lane