Message-ID: <931c23465c331fc3d53073cdefa53bad464b0469.camel@j-davis.com>
Subject: Re: pgsql: Fix search_path to a safe value during maintenance
 operations.
From: Jeff Davis <pgsql@j-davis.com>
To: Nathan Bossart <nathandbossart@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>
Cc: Robert Haas <robertmhaas@gmail.com>, Noah Misch <noah@leadboat.com>,
	"pgsql-hackers@postgresql.org"
	 <pgsql-hackers@postgresql.org>
Date: Thu, 06 Jul 2023 00:55:14 -0700
In-Reply-To: <20230630050921.GA2640352@nathanxps13>
References: <20230612170510.GA201972@gust.leadboat.com>
	 <f53df2dbe11bb42764bcdd003a54aa29c9bb6137.camel@j-davis.com>
	 <20230613182920.GA259321@gust.leadboat.com>
	 <1799839.1686687804@sss.pgh.pa.us>
	 <4df537f5a0d8c0ceac3eec3809d1144880b8e76d.camel@j-davis.com>
	 <CA+TgmoYtJU0KknWr11W--wK=4eJtdHOgupyT=beZVPC8P=o+YA@mail.gmail.com>
	 <578fb4be80247570e6a05924908765a0b345971e.camel@j-davis.com>
	 <CA+TgmoZVCHERUkXhAMT2Er-sKBc5C6_iX+TpxxivBevDHzq2TQ@mail.gmail.com>
	 <43bbc9f7318057f51552d5986830908cb018dadf.camel@j-davis.com>
	 <1659699.1688086436@sss.pgh.pa.us> <20230630050921.GA2640352@nathanxps13>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4-0ubuntu1 
MIME-Version: 1.0
Archived-At: 
 <https://www.postgresql.org/message-id/931c23465c331fc3d53073cdefa53bad464b0469.camel%40j-davis.com>
Precedence: bulk

On Thu, 2023-06-29 at 22:09 -0700, Nathan Bossart wrote:
> On Thu, Jun 29, 2023 at 08:53:56PM -0400, Tom Lane wrote:
> > I'm leaning to Robert's thought that we need to revert this for
> > now,
> > and think harder about how to make it work cleanly and safely.
>=20
> Since it sounds like this is headed towards a revert, here's a patch
> for
> removing MAINTAIN and pg_maintain.

It was difficult to review standalone, so I tried a quick version
myself and ended up with very similar results. The only substantial
difference was that I put back:


+               if (!vacuum_is_relation_owner(relid, classForm,
options))
+                       continue;


in get_all_vacuum_rels() whereas your patch left it out -- double-check
that we're doing the right thing there.

Also remember to bump the catversion. Other than that, it looks good to
me.

Regards,
	Jeff Davis