Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lTYOs-00007q-D5 for pgsql-committers@arkaria.postgresql.org; Mon, 05 Apr 2021 23:12:54 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lTYOr-0003oy-A6 for pgsql-committers@arkaria.postgresql.org; Mon, 05 Apr 2021 23:12:53 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lTYOr-0003or-50 for pgsql-committers@lists.postgresql.org; Mon, 05 Apr 2021 23:12:53 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lTYOp-0007uM-7A for pgsql-committers@lists.postgresql.org; Mon, 05 Apr 2021 23:12:52 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 135NCnI3932678; Mon, 5 Apr 2021 19:12:49 -0400 From: Tom Lane To: Michael Paquier cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Refactor all TAP test suites doing connection checks In-reply-to: <932059.1617663467@sss.pgh.pa.us> References: <513200.1617634642@sss.pgh.pa.us> <932059.1617663467@sss.pgh.pa.us> Comments: In-reply-to Tom Lane message dated "Mon, 05 Apr 2021 18:57:47 -0400" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <932676.1617664369.1@sss.pgh.pa.us> Date: Mon, 05 Apr 2021 19:12:49 -0400 Message-ID: <932677.1617664369@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk I wrote: > Michael Paquier writes: >> So, the problem is with on_error_stop. > No, I bet it is with "now defines a SQL query". That means there's > something to be stuffed down the pipe. I can confirm that removing the on_error_stop parameter as you propose does *not* fix it. regards, tom lane