From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Refactor all TAP test suites doing connection checks
In-reply-to: <932059.1617663467@sss.pgh.pa.us>
References: <E1lTDox-0006rF-OV@gemulon.postgresql.org>
 <513200.1617634642@sss.pgh.pa.us> <YGuSe6Q484Eshj2n@paquier.xyz>
 <932059.1617663467@sss.pgh.pa.us>
Comments: In-reply-to Tom Lane <tgl@sss.pgh.pa.us>
	message dated "Mon, 05 Apr 2021 18:57:47 -0400"
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="----- =_aaaaaaaaaa0"
Content-ID: <933112.1617664999.0@sss.pgh.pa.us>
Date: Mon, 05 Apr 2021 19:23:43 -0400
Message-ID: <933130.1617665023@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/933130.1617665023%40sss.pgh.pa.us>
Precedence: bulk

------- =_aaaaaaaaaa0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <933112.1617664999.1@sss.pgh.pa.us>

What does seem to fix it reliably is the attached.

			regards, tom lane


------- =_aaaaaaaaaa0
Content-Type: text/x-diff; name="dont-send-query-in-connect_fails.patch";
	charset="us-ascii"
Content-ID: <933112.1617664999.2@sss.pgh.pa.us>
Content-Description: dont-send-query-in-connect_fails.patch

diff --git a/src/test/perl/PostgresNode.pm b/src/test/perl/PostgresNode.pm
index bbde34c..07a9167 100644
--- a/src/test/perl/PostgresNode.pm
+++ b/src/test/perl/PostgresNode.pm
@@ -1938,7 +1938,7 @@ sub connect_fails
 	# have set up things properly, and this should not block.
 	my ($ret, $stdout, $stderr) = $self->psql(
 		'postgres',
-		"SELECT \$\$connected with $connstr\$\$",
+		undef, # don't try to send a query
 		extra_params => ['-w'],
 		connstr      => "$connstr");
 

------- =_aaaaaaaaaa0--