From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Refactor all TAP test suites doing connection checks
In-reply-to: <YGunFpb3U9zi5DV4@paquier.xyz>
References: <E1lTDox-0006rF-OV@gemulon.postgresql.org>
 <513200.1617634642@sss.pgh.pa.us> <YGuSe6Q484Eshj2n@paquier.xyz>
 <932059.1617663467@sss.pgh.pa.us> <933130.1617665023@sss.pgh.pa.us>
 <YGunFpb3U9zi5DV4@paquier.xyz>
Comments: In-reply-to Michael Paquier <michael@paquier.xyz>
	message dated "Tue, 06 Apr 2021 09:11:02 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <935456.1617668131.1@sss.pgh.pa.us>
Date: Mon, 05 Apr 2021 20:15:31 -0400
Message-ID: <935457.1617668131@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/935457.1617668131%40sss.pgh.pa.us>
Precedence: bulk

Michael Paquier <michael@paquier.xyz> writes:
> On Mon, Apr 05, 2021 at 07:23:43PM -0400, Tom Lane wrote:
>> What does seem to fix it reliably is the attached.

> Thanks for confirming.  I am still surprised that this has not popped
> up as an issue until now.  Could that be because those animals have
> never run the LDAP, SSL or kerberos test suites over the years?

Dunno.  Certainly most animals that enable TAP at all should be
running the "authentication" test, but those others all need to
be manually enabled, I believe.  My own animals run the SSL test
but not LDAP or kerberos.

I'm fairly sure that we've previously fixed this exact same issue
in some tests that expected a connection failure ...

			regards, tom lane