From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Refactor all TAP test suites doing connection checks
In-reply-to: <YGuq7obSb5BviTHz@paquier.xyz>
References: <E1lTDox-0006rF-OV@gemulon.postgresql.org>
 <513200.1617634642@sss.pgh.pa.us> <YGuSe6Q484Eshj2n@paquier.xyz>
 <932059.1617663467@sss.pgh.pa.us> <933130.1617665023@sss.pgh.pa.us>
 <YGunFpb3U9zi5DV4@paquier.xyz> <935457.1617668131@sss.pgh.pa.us>
 <YGuq7obSb5BviTHz@paquier.xyz>
Comments: In-reply-to Michael Paquier <michael@paquier.xyz>
	message dated "Tue, 06 Apr 2021 09:27:26 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <936575.1617669613.1@sss.pgh.pa.us>
Date: Mon, 05 Apr 2021 20:40:13 -0400
Message-ID: <936576.1617669613@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/936576.1617669613%40sss.pgh.pa.us>
Precedence: bulk

Michael Paquier <michael@paquier.xyz> writes:
> On Mon, Apr 05, 2021 at 08:15:31PM -0400, Tom Lane wrote:
>> Dunno.  Certainly most animals that enable TAP at all should be
>> running the "authentication" test, but those others all need to
>> be manually enabled, I believe.  My own animals run the SSL test
>> but not LDAP or kerberos.

> The SSL tests have always sent down a query even for scenarios where
> the connection would fail, but they have used command_fails_like()
> rather than PostgresNode::psql.  The puzzle does not seem complete.

Well, since it's a race condition it's obviously going to be sensitive to
machine speed.  I think that Perl version, or more likely version of
IPC::Run or a related module, may enter into it too.  prairiedog has
gotten through the tests several times since yesterday without failing,
yet it's significantly slower than the other PPC Mac I was able to
consistently reproduce the problem on.  I don't think those two have
the same vintage of Perl installation, though, so Perl version seems
like a likely explanation.

			regards, tom lane