Subject: Re: pgsql: SQL-standard function body
To: Tom Lane <tgl@sss.pgh.pa.us>, Andres Freund <andres@anarazel.de>
Cc: pgsql-committers@lists.postgresql.org
References: <E1lUEF5-00027L-N4@gemulon.postgresql.org>
 <20210407225806.majgznh4lk34hjvu@alap3.anarazel.de>
 <1730972.1617836766@sss.pgh.pa.us>
From: Peter Eisentraut <peter@eisentraut.org>
Message-ID: <93cd20a5-1d4a-6cc9-a70a-41a7c8c4d80a@eisentraut.org>
Date: Thu, 8 Apr 2021 08:25:16 +0200
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0)
 Gecko/20100101 Thunderbird/78.9.0
MIME-Version: 1.0
In-Reply-To: <1730972.1617836766@sss.pgh.pa.us>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/93cd20a5-1d4a-6cc9-a70a-41a7c8c4d80a%40eisentraut.org>
Precedence: bulk

On 08.04.21 01:06, Tom Lane wrote:
> Andres Freund <andres@anarazel.de> writes:
>> On 2021-04-07 19:53:35 +0000, Peter Eisentraut wrote:
>>> SQL-standard function body
> 
>> This is turning the BF red:
>> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=rhinoceros&dt=2021-04-07%2022%3A52%3A19
>> Might be force_parallel_mode=regress related.
> 
> Yeah.  On my machine, it's fine without force_parallel_mode and
> crashes with that.  Looks like query text is not getting passed
> to the parallel worker in some cases.

There does not appear to be any indication in CreateQueryDesc() or for 
es_sourceText that the query source text needs to be not NULL (unlike 
PortalDefineQuery() for example).  If we want that to be the case, an 
assert in CreateQueryDesc() would be a straightforward way to catch 
this.  But for example code in CreateExecutorState() and 
executor_errposition() is prepared to have es_sourceText be NULL, so 
relative to that, the fix that Andres put into ExecInitParallelPlan() to 
handle that as well seems appropriate.