Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nZzVr-0004k0-EV for pgsql-hackers@arkaria.postgresql.org; Thu, 31 Mar 2022 18:27:15 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nZzVq-0007ah-92 for pgsql-hackers@arkaria.postgresql.org; Thu, 31 Mar 2022 18:27:14 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nZzVp-0007aX-WA for pgsql-hackers@lists.postgresql.org; Thu, 31 Mar 2022 18:27:13 +0000 Received: from relay2-d.mail.gandi.net ([217.70.183.194]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nZzVl-0007yn-Gu for pgsql-hackers@lists.postgresql.org; Thu, 31 Mar 2022 18:27:13 +0000 Received: (Authenticated sender: adsend@dunslane.net) by mail.gandi.net (Postfix) with ESMTPSA id EF73340005; Thu, 31 Mar 2022 18:27:05 +0000 (UTC) Message-ID: <94484e78-4b66-094d-125c-95b194bb1a3d@dunslane.net> Date: Thu, 31 Mar 2022 14:27:04 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: pgsql: Add 'basebackup_to_shell' contrib module. Content-Language: en-US To: Robert Haas , Tom Lane Cc: Nathan Bossart , Andres Freund , Thomas Munro , PostgreSQL Hackers , Magnus Hagander References: <20220329222504.aylyimyub6igsvpy@alap3.anarazel.de> <20220330163024.fsbpbxwxh5oo2ktx@alap3.anarazel.de> <20220330165450.3lruwky7eveddsvq@alap3.anarazel.de> <285252.1648671723@sss.pgh.pa.us> <20220330223531.GA134543@nathanxps13> <472639.1648684865@sss.pgh.pa.us> <485495.1648692468@sss.pgh.pa.us> <639823.1648740735@sss.pgh.pa.us> <61e2e2c0-1b1c-3b48-4d5c-2fe581e63121@dunslane.net> <648071.1648745113@sss.pgh.pa.us> From: Andrew Dunstan In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 3/31/22 14:12, Robert Haas wrote: > On Thu, Mar 31, 2022 at 12:56 PM Robert Haas wrote: >> I agree. That's exactly what I said in >> http://postgr.es/m/CA+TgmoasOhqLR=TSYmHd4TyX-qnfwtde_u19ZphKunpSCkh_iw@mail.gmail.com >> ... > OK, so I pushed a commit adding that incantation to the test script, > and also a comment explaining why it's there. Possibly we ought to go > add similar comments to other places where this incantation is used, > or find a way to make this all a bit more self-documenting, but that > doesn't necessarily need to be done today. > > The buildfarm does look rather green at the moment, though, so I'm not > sure how I know whether this "worked". You should know when jacana reports next (in the next hour or three), as it's not set up for Unix sockets. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com