Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pFyqI-0004W1-1b for pgsql-committers@arkaria.postgresql.org; Thu, 12 Jan 2023 14:46:10 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pFyqG-0007uO-Vn for pgsql-committers@arkaria.postgresql.org; Thu, 12 Jan 2023 14:46:08 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pFyqG-0007uF-Oy for pgsql-committers@lists.postgresql.org; Thu, 12 Jan 2023 14:46:08 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pFyqC-0004zW-Ah for pgsql-committers@lists.postgresql.org; Thu, 12 Jan 2023 14:46:08 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 30CEk0Dh950929; Thu, 12 Jan 2023 09:46:00 -0500 From: Tom Lane To: Andrew Dunstan cc: Amit Langote , pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Improve handling of inherited GENERATED expressions. In-reply-to: <16b06d39-e36d-afa3-59d1-9c71ddfa59b7@dunslane.net> References: <16b06d39-e36d-afa3-59d1-9c71ddfa59b7@dunslane.net> Comments: In-reply-to Andrew Dunstan message dated "Thu, 12 Jan 2023 09:12:51 -0500" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <950927.1673534760.1@sss.pgh.pa.us> Date: Thu, 12 Jan 2023 09:46:00 -0500 Message-ID: <950928.1673534760@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Andrew Dunstan writes: > On 2023-01-12 Th 08:30, Amit Langote wrote: >> IIUC, by deciding to not back-patch this, we're expecting the user to >> fix any child tables in the old cluster that have unsupported (in v16) >> properties before upgrading to v16, right? If that is indeed the >> case, maybe this is again a case where TestUpgradeXversion.pm needs >> tweaking? > OK, please tell me exactly what I'm meant to tweak :-) Yeah. I think best bet may be to drop the problematic table(s), as we've done for other de-supported DDL situations. A quick experiment suggests that DROP TABLE gtest_normal_child; DROP TABLE gtest_normal_child2; should do it. I can work on a better-tested patch for TestUpgradeXversion.pm, but I have a couple other commitments today so it may take a bit of time. regards, tom lane