Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qT8NP-008Wd7-0y for pgsql-committers@arkaria.postgresql.org; Mon, 07 Aug 2023 22:06:59 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1qT8NN-00Bvo7-8c for pgsql-committers@arkaria.postgresql.org; Mon, 07 Aug 2023 22:06:57 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qT8NN-00Bvnz-1j for pgsql-committers@lists.postgresql.org; Mon, 07 Aug 2023 22:06:57 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qT8NK-001AbK-Dq for pgsql-committers@lists.postgresql.org; Mon, 07 Aug 2023 22:06:56 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 377M6pMb954639; Mon, 7 Aug 2023 18:06:51 -0400 From: Tom Lane To: David Rowley cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Don't Memoize lateral joins with volatile join conditions In-reply-to: References: <768799.1691413325@sss.pgh.pa.us> Comments: In-reply-to David Rowley message dated "Tue, 08 Aug 2023 09:56:41 +1200" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <954637.1691446011.1@sss.pgh.pa.us> Date: Mon, 07 Aug 2023 18:06:51 -0400 Message-ID: <954638.1691446011@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk David Rowley writes: > On Tue, 8 Aug 2023 at 01:02, Tom Lane wrote: >> Is this really something to be pushing into stable branches less than >> 12 hours before a release wrap? > My apologies. I had been under the impression that the go-no window > was between stamp and tag and *that* was the window that was used for > a buildfarm cycle. It sounds like it's not quite as black and white as > that. I'm not aware of any documentation which gives guidance on > this. Hmm. Customarily we avoid pushing stuff into due-for-release branches beginning 48-72 hours before the wrap, and then continuing until the tags are applied ~24 hours after wrap. The pause before wrap is to allow a complete buildfarm test cycle even on slower machines. The pause after wrap is to wait for feedback from packagers. > * https://wiki.postgresql.org/wiki/Committing_checklist I thought we had something written down there after the last discussion of this point, but maybe it was hanging fire because we hadn't chosen a specific definition of when to start the pause. > (I'm assuming backing the patch out now won't improve the situation, > but please correct me if you think I'm wrong on that) No, I've already made the tarballs. I did look closely at the patch and decided it was probably harmless and not in need of reversion. I'm just whining because this wasn't following process. regards, tom lane