Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1ipaXY-0001VF-G6 for pgsql-hackers@arkaria.postgresql.org; Thu, 09 Jan 2020 16:20:08 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1ipaXX-00060J-2L for pgsql-hackers@arkaria.postgresql.org; Thu, 09 Jan 2020 16:20:07 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1ipaXW-0005yw-MF for pgsql-hackers@lists.postgresql.org; Thu, 09 Jan 2020 16:20:06 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ipaXU-0008II-Dv for pgsql-hackers@postgresql.org; Thu, 09 Jan 2020 16:20:05 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id 009GJvM0009595; Thu, 9 Jan 2020 11:19:57 -0500 From: Tom Lane To: Peter Eisentraut cc: Christoph Berg , Robert Haas , Andres Freund , Amit Kapila , PostgreSQL Hackers Subject: Re: pgsql: Add basic TAP tests for psql's tab-completion logic. In-reply-to: <72457f7b-4eed-c238-9e21-c113f793cf36@2ndquadrant.com> References: <20200103110128.GA28967@msg.df7cb.de> <13708.1578059577@sss.pgh.pa.us> <25771.1578249042@sss.pgh.pa.us> <20200106105608.GB18560@msg.df7cb.de> <3764.1578323719@sss.pgh.pa.us> <20200106191303.GA3975@msg.df7cb.de> <19973.1578351988@sss.pgh.pa.us> <28773.1578436137@sss.pgh.pa.us> <20200109145900.GF4192@msg.df7cb.de> <7656.1578585011@sss.pgh.pa.us> <72457f7b-4eed-c238-9e21-c113f793cf36@2ndquadrant.com> Comments: In-reply-to Peter Eisentraut message dated "Thu, 09 Jan 2020 17:10:10 +0100" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <9593.1578586797.1@sss.pgh.pa.us> Date: Thu, 09 Jan 2020 11:19:57 -0500 Message-ID: <9594.1578586797@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Peter Eisentraut writes: > On 2020-01-09 16:50, Tom Lane wrote: >> That would disable psql's tab completion, command editing, and history >> altogether, which I doubt is what you want for production builds. >> If we conclude we can't work around the testing issues for ancient >> libedit, probably the right answer is to provide a switch to >> disable just the test. I've been trying to dance around that >> conclusion, but maybe we should just do it and move on. > I think he means something like > make check with_readline=no > not for the actual build. Oh, I see. I'd rather not codify that though, because it risks problems if that symbol ever gets used any other way. I was thinking of making the test script check for some independent environment variable, say SKIP_READLINE_TESTS. regards, tom lane