Message-ID: <95a8a6e710d4c94a0ea71f4687c6ac93e5132754.camel@cybertec.at>
Subject: Re: pgsql: Allow insert and update tuple routing and COPY for
 foreign table
From: Laurenz Albe <laurenz.albe@cybertec.at>
To: Andres Freund <andres@anarazel.de>
Cc: Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>, Robert Haas
	 <rhaas@postgresql.org>, pgsql-committers@lists.postgresql.org,
	pgsql-hackers@lists.postgresql.org
Date: Tue, 23 Apr 2019 08:59:14 +0200
In-Reply-To: <20190422210751.sbgtmweuaodcu2er@alap3.anarazel.de>
References: <E1f4aif-0004qo-A6@gemulon.postgresql.org>
	 <ed0b7471dce91169d871347cf003d8094ab96895.camel@cybertec.at>
	 <5CBDB770.2060602@lab.ntt.co.jp>
	 <b459d1b1b4eb8c0d538a2c5b70e131af3c391954.camel@cybertec.at>
	 <20190422202703.4mgtqv3mqtamsgel@alap3.anarazel.de>
	 <333528b0ada7111cb6bc51cae6158f92d4e9d0f1.camel@cybertec.at>
	 <20190422210751.sbgtmweuaodcu2er@alap3.anarazel.de>
Organization: Cybertec
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Mon, 2019-04-22 at 14:07 -0700, Andres Freund wrote:
> How about just applying the patch from v12 on?
> > Then it is a behavior change in a major release, which is acceptable.
> > It requires the imaginary FDW above to add an empty BeginForeignInsert
> > callback function, but will unbreak FDW that slept through the change
> > that added COPY support.
> 
> I fail to see the advantage. It'll still require FDWs to be fixed to
> work correctly for v11, but additionally adds another set of API
> differences that needs to be fixed by another set of FDWs.  I think this
> ship simply has sailed.

I can accept that (having fixed my own FDW), but I am worried that it will
cause problems for FDW users.  Well, I guess they can always avoid COPY if
they don't want FDWs to crash.

Yours,
Laurenz Albe