Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pRJcy-0000UG-Jh for pgsql-committers@arkaria.postgresql.org; Sun, 12 Feb 2023 21:11:16 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pRJcx-0001NE-GA for pgsql-committers@arkaria.postgresql.org; Sun, 12 Feb 2023 21:11:15 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pRJcx-0001N1-8v for pgsql-committers@lists.postgresql.org; Sun, 12 Feb 2023 21:11:15 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pRJcu-0001YP-S2 for pgsql-committers@lists.postgresql.org; Sun, 12 Feb 2023 21:11:14 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 31CLB8R1960945; Sun, 12 Feb 2023 16:11:08 -0500 From: Tom Lane To: Andres Freund cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Make pg_bsd_indent's .h files inclusion-order-safe. In-reply-to: References: Comments: In-reply-to Andres Freund message dated "Sun, 12 Feb 2023 12:12:55 -0800" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <960943.1676236268.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Sun, 12 Feb 2023 16:11:08 -0500 Message-ID: <960944.1676236268@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Andres Freund writes: > Cfbot didn't catch this, because it only triggered a warning, not a fail= ure. We probably should add -Werror? Yeah -- nobody is going to go digging through cfbot logs for warnings, especially when they know that the Compiler Warnings task is supposed to complain about those. I don't think -Werror helps any though; it's a matter of whether the cfbot is paying attention to headerscheck's exit status ... regards, tom lane