Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pRJqo-0001F2-Gj for pgsql-committers@arkaria.postgresql.org; Sun, 12 Feb 2023 21:25:34 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pRJqn-0005jo-CY for pgsql-committers@arkaria.postgresql.org; Sun, 12 Feb 2023 21:25:33 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pRJqn-0005je-5D for pgsql-committers@lists.postgresql.org; Sun, 12 Feb 2023 21:25:33 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pRJql-0001gC-6Y for pgsql-committers@lists.postgresql.org; Sun, 12 Feb 2023 21:25:32 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 31CLPS3k962482; Sun, 12 Feb 2023 16:25:28 -0500 From: Tom Lane To: Andres Freund cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Make pg_bsd_indent's .h files inclusion-order-safe. In-reply-to: <3A6C72BD-50D3-4B8B-B614-CDE83E7E1FBC@anarazel.de> References: <960944.1676236268@sss.pgh.pa.us> <3A6C72BD-50D3-4B8B-B614-CDE83E7E1FBC@anarazel.de> Comments: In-reply-to Andres Freund message dated "Sun, 12 Feb 2023 13:20:46 -0800" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <962480.1676237128.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Sun, 12 Feb 2023 16:25:28 -0500 Message-ID: <962481.1676237128@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Andres Freund writes: > On February 12, 2023 1:11:08 PM PST, Tom Lane wrote: >> I don't think -Werror helps any though; it's a matter of whether the >> cfbot is paying attention to headerscheck's exit status ... > Thomas fixed that part a while ago, but it'll just return 0 if it just i= s a warning... Hmm, but why'd the buildfarm complain then? ... oh, because it checks for nonempty output as well as nonzero exit status. regards, tom lane