Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pRKs6-0004sU-NJ for pgsql-committers@arkaria.postgresql.org; Sun, 12 Feb 2023 22:30:58 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pRKs5-0007Pm-7V for pgsql-committers@arkaria.postgresql.org; Sun, 12 Feb 2023 22:30:57 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pRKs5-0007MK-02 for pgsql-committers@lists.postgresql.org; Sun, 12 Feb 2023 22:30:57 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pRKs1-0002Re-Nv for pgsql-committers@lists.postgresql.org; Sun, 12 Feb 2023 22:30:56 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 31CMUosu969566; Sun, 12 Feb 2023 17:30:50 -0500 From: Tom Lane To: Andres Freund cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Make pg_bsd_indent's .h files inclusion-order-safe. In-reply-to: <20230212222141.hsrabsjgzksfuq77@awork3.anarazel.de> References: <960944.1676236268@sss.pgh.pa.us> <3A6C72BD-50D3-4B8B-B614-CDE83E7E1FBC@anarazel.de> <962481.1676237128@sss.pgh.pa.us> <20230212222141.hsrabsjgzksfuq77@awork3.anarazel.de> Comments: In-reply-to Andres Freund message dated "Sun, 12 Feb 2023 14:21:41 -0800" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <969564.1676241050.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Sun, 12 Feb 2023 17:30:50 -0500 Message-ID: <969565.1676241050@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Andres Freund writes: > Obviously that approach could be re-implemented for CI, but givent that = it > additionally is somewhat required to make use of headerscheck/cplusplusc= heck > locally, it feels better to solve it in headerscheck. And the easiest wa= y for > that seems to be -Werror? Agreed --- although right now, headerscheck goes out of its way to be agnostic about what compiler and cflags are used. Having it assume that -Werror will work seems a bit ugly. Not sure that it's a problem in practice though. (BTW, we'll have to fix these scripts sometime to work in non-Make builds.) regards, tom lane